Remove the V1 catalog-test machinery - #3419
Merged
Merged
Conversation
This was referenced Aug 27, 2026
jgraettinger
force-pushed
the
johnny/v2-tests-4-publication-tests
branch
from
August 30, 2026 17:56
473159e to
4d689b9
Compare
jgraettinger
force-pushed
the
johnny/v2-tests-5-remove-v1
branch
from
August 30, 2026 17:56
846d282 to
41b8bff
Compare
jgraettinger
force-pushed
the
johnny/v2-tests-4-publication-tests
branch
from
August 30, 2026 18:08
4d689b9 to
12b25e5
Compare
jgraettinger
force-pushed
the
johnny/v2-tests-5-remove-v1
branch
from
August 30, 2026 18:09
41b8bff to
1848274
Compare
jgraettinger
force-pushed
the
johnny/v2-tests-4-publication-tests
branch
from
August 31, 2026 22:08
12b25e5 to
893de73
Compare
jgraettinger
force-pushed
the
johnny/v2-tests-5-remove-v1
branch
from
August 31, 2026 22:08
1848274 to
a3d85b3
Compare
jgraettinger
force-pushed
the
johnny/v2-tests-4-publication-tests
branch
from
August 31, 2026 22:19
893de73 to
a7bf70c
Compare
jgraettinger
force-pushed
the
johnny/v2-tests-5-remove-v1
branch
from
August 31, 2026 22:19
a3d85b3 to
d36abab
Compare
jgraettinger
force-pushed
the
johnny/v2-tests-4-publication-tests
branch
from
August 31, 2026 22:46
a7bf70c to
a3a147b
Compare
jgraettinger
force-pushed
the
johnny/v2-tests-5-remove-v1
branch
from
August 31, 2026 22:46
d36abab to
c10a65d
Compare
jgraettinger
force-pushed
the
johnny/v2-tests-4-publication-tests
branch
from
September 1, 2026 00:51
a3a147b to
e99bf9f
Compare
jgraettinger
force-pushed
the
johnny/v2-tests-5-remove-v1
branch
from
September 1, 2026 00:51
c10a65d to
ad136ad
Compare
jgraettinger
force-pushed
the
johnny/v2-tests-4-publication-tests
branch
from
September 1, 2026 01:34
e99bf9f to
5727a84
Compare
jgraettinger
force-pushed
the
johnny/v2-tests-5-remove-v1
branch
from
September 1, 2026 01:34
ad136ad to
f66cad3
Compare
jgraettinger
force-pushed
the
johnny/v2-tests-4-publication-tests
branch
from
September 1, 2026 04:46
5727a84 to
8c84db4
Compare
jgraettinger
force-pushed
the
johnny/v2-tests-5-remove-v1
branch
from
September 1, 2026 04:46
f66cad3 to
9048fea
Compare
jgraettinger
force-pushed
the
johnny/v2-tests-4-publication-tests
branch
from
September 1, 2026 15:34
8c84db4 to
d7b8fb9
Compare
jgraettinger
force-pushed
the
johnny/v2-tests-5-remove-v1
branch
from
September 1, 2026 15:34
9048fea to
15efed1
Compare
jgraettinger
force-pushed
the
johnny/v2-tests-4-publication-tests
branch
from
September 1, 2026 16:17
d7b8fb9 to
f53a04b
Compare
jgraettinger
force-pushed
the
johnny/v2-tests-5-remove-v1
branch
from
September 1, 2026 16:17
15efed1 to
19ea1a2
Compare
jgraettinger
force-pushed
the
johnny/v2-tests-4-publication-tests
branch
from
September 1, 2026 21:43
f53a04b to
875f483
Compare
Base automatically changed from
johnny/v2-tests-4-publication-tests
to
master
September 2, 2026 13:40
jgraettinger
dismissed
williamhbaker’s stale review
September 2, 2026 13:40
The base branch was changed.
Nothing drives it any more: CI and publication tests both run on `catalog-tests`
as of the preceding commits.
Deleted: `flowctl-go test`, `flowctl-go api test`, and `flowctl-go
temp-data-plane`; `sys_proc_attr_{linux,bsd}.go`, whose `SysProcAttr` had exactly
one caller in temp-data-plane; `go/runtime/testing.go`; and all of `go/testing/`
— the graph, clock, action, and cluster driver, whose semantics now live in
`crates/catalog-tests` as a Rust port. `deriveApp.ClearRegistersForTest` goes
with its sole caller there.
`FlowConsumerConfig.Flow.TestAPIs` and the `--flow.test-apis` flag are removed,
along with the `pf.RegisterTestingServer` block they gated. The flag also gated
control-plane construction, which was skipped when it was set because a temp data
plane has no control plane to talk to; only temp-data-plane ever passed the flag,
so for every real consumer that term was already true.
`derive.Request.Reset` stays in the connector protocol — it is the mechanism the
V2 flow now drives.
The last implementation went away in the preceding commit, so the definition can follow: `ResetStateRequest`/`Response`, `AdvanceTimeRequest`/`Response`, `IngestRequest`/`Response`, and the `Testing` service itself. Its three RPCs are all superseded. ResetState is now `derive.Request.Reset`, driven shard-locally by the runtime. AdvanceTime is gone entirely — synthetic test time is a counter inside `catalog-tests`, not something a data plane advances. Ingest is a combine-by-key and an append to an in-memory collection store. Kept separate from the previous commit so that ~2,950 lines of generated churn across flow.pb.go, proto-flow, and proto-grpc don't bury the hand-written deletions there.
jgraettinger
force-pushed
the
johnny/v2-tests-5-remove-v1
branch
from
September 2, 2026 14:33
19ea1a2 to
a358445
Compare
williamhbaker
approved these changes
Sep 2, 2026
github-actions
Bot
added
the
pending:agent
github-actions
Bot
added
pending:flowctl
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Stack 5 of 5, and pure deletion. Nothing drives the V1 catalog-test machinery any more: CI runs on
catalog-testsas of #3417, and publication tests as of #3418.Two commits, kept separate so ~2,950 lines of proto regen don't bury the hand-written Go deletions:
go: remove the V1 catalog-test machineryproto: remove the Testing RPC serviceWorkflow steps:
flowctl-go test,flowctl-go api test, andflowctl-go temp-data-planeno longer exist. Useflowctl raw test --source ...(#3417).Documentation links affected:
None.
Notes for reviewers:
Read the first commit; the second is almost entirely regenerated code.
One flag worth a second look.
FlowConsumerConfig.Flow.TestAPIs/--flow.test-apisis removed along with thepf.RegisterTestingServerblock it gated. It also gated something non-obvious: control-plane construction was skipped when it was set, because a temp data plane has no control plane to talk to. Only temp-data-plane ever passed the flag, so for every real consumer that term was already true and dropping it changes nothing.The
Testingservice's three RPCs are all superseded — ResetState byderive.Request.Reset, AdvanceTime by a counter insidecatalog-tests, and Ingest by a combine-by-key and an append to an in-memory collection store.derive.Request.Resetitself stays in the connector protocol: it is the mechanism the V2 flow now drives.Stack — each PR is based on the one above it, so review only the top commits of each.
flowctl raw test#3417 — catalog-tests: the harness, andflowctl raw test