ci: drop redundant build step, document why clippy needs nightly - #422
Merged
Conversation
cargo test compiles everything the removed cargo build step did, so the separate build step only duplicated work on every run. Also add a comment explaining that the rustfmt_and_clippy job cannot move to stable: .rustfmt.toml uses unstable rustfmt options, and clippy with --all-features builds matrix-transpose's simd-transpose feature, which requires the nightly-only portable_simd language feature.
sinui0
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two small CI cleanups in
rust.yml:cargo buildstep from the Build and Test job.cargo testcompiles the same dev-profile code plus the test binaries, so the build step duplicated work on every run..rustfmt.tomluses unstable options (imports_granularity,wrap_comments)--all-features, which enablesmatrix-transpose'ssimd-transposefeature — that requires the nightly-onlyportable_simdlanguage feature and does not compile on stableNo behavioral change to what CI checks.