Add MIT LICENSE file - #496
Open
pankajjagtapp wants to merge 1 commit into
Open
Conversation
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
📊 Forge Coverage ReportGenerated by workflow run #793 |
Contributor
|
are we sure we want to declare our protocol contracts under MIT License and not BUSL or GPL? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The README links to
[MIT License](LICENSE)but the file has never existed, so the link 404s and GitHub reports no license for this repo. This adds it.The text is verbatim MIT and matches
etherfi-protocol/.github, including theCopyright (c) 2023 etherfi-protocolline, so GitHub picks it up automatically.Licensing check
I checked every
.solfile undersrc/before adding a blanket license. Of the 54 contracts that are ether.fi's own code, 52 declareSPDX-License-Identifier: MITand none declare anything else.The non-MIT files under
src/are all vendored third-party interfaces that keep their upstream licenses:IETHPOSDeposit.solIDepositContract.solITimelock.solIRateProvider.solILayerZeroTellerWithRateLimiting.solPer-file SPDX headers govern those files, so a root MIT LICENSE does not reach them. I added a line to the README saying as much, rather than editing the LICENSE text, which would break GitHub's license detection.
Worth a follow-up
Three files under
src/carry no SPDX header at all:src/rewards/EtherFiRewardsRouter.solsrc/interfaces/IWETH.solsrc/archive/BucketRateLimiter.solEtherFiRewardsRouter.solis deployed, so it's the one worth labelling. I left them alone here to keep this PR to licensing metadata.Context
ether.fi is being added to the pooled staking page on ethereum.org (ethereum/ethereum-org-website#19097). Their listing policy asks whether the project is open source, and the entry claims
isFoss: true. A LICENSE file makes that checkable.Note
Low Risk
Documentation and licensing metadata only; no contract or runtime behavior changes.
Overview
Adds a root MIT LICENSE so the README’s
[MIT License](LICENSE)link resolves and GitHub can detect the project license (text aligned withetherfi-protocol/.github, includingCopyright (c) 2023 etherfi-protocol).Updates the License section in the README to note that vendored interfaces under
src/interfaces/remain under their per-file SPDX headers (e.g. EigenLayer BUSL-1.1, deposit contract interfaces), and are not relicensed by the root MIT file.Reviewed by Cursor Bugbot for commit 64e06df. Bugbot is set up for automated code reviews on this repo. Configure here.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.