fix(tui): Clear the terminal buffer when the viewport is resized - #35
Merged
Conversation
Growing the terminal exposes cells that ratatui never repaints, because the frame-wide Clear in draw() only covers the area it currently believes is the viewport. Wipe the whole buffer on Event::Resize so the next frame starts clean instead of painting around leftover text. Refs #34 Claude-Session: https://claude.ai/code/session_01PvhTkPF3fvjPUh5ao9MeWL
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe TUI now clears the terminal after resize events. The event loop passes only key-press events to the application and ignores other event types. ChangesTUI resize handling
Estimated code review effort: 2 (Simple) | ~5 minutes Poem
✨ Finishing Touches📝 Generate docstrings
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Growing the terminal left stale cells on screen.
draw()already renders aClearwidget overframe.area(), but that only wipes the region ratatuicurrently treats as the viewport, so cells the viewport just expanded into keep
whatever the terminal had in them.
Handling
Event::Resizeby callingterminal.clear()makes the next framestart from a wiped buffer.
Changes
src/tui.rs: replace the two early-continue guards inevent_loopwith asingle
matchonevent::read(), adding anEvent::Resize(..)arm thatclears the terminal. Key handling is unchanged.
Test plan
cargo fmt --checkRUSTFLAGS="-Dwarnings" cargo clippy --all-targetscargo test(155 unit tests + 2 doctests pass)limits tui, shrink the terminal, then grow it back. Before thischange the newly exposed rows held leftover shell output; after it they are
blank and redrawn by the next frame.
Fixes #34