fix(reader): preserve active turns across presentation rebuilds - #949
Merged
Conversation
Only remap navigation targets that were already pending before a reader presentation rebuild, leaving restoration to committed anchors and adapter-owned snapshots. Clarify explicit command ownership and end-page projection boundaries.
everpcpc
marked this pull request as ready for review
August 7, 2026 02:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
navigationTargetexclusive to explicit navigation commands during reader presentation rebuilds.AGENTS.md.Why
This follows up on #948. A rebuild during an in-flight reader transition could synthesize a command for the previously committed page. After the user transition committed its newer page, an adapter continuation could replay that stale command and navigate backward.
The fix removes the competing restoration command instead of adding timing flags or generations. Existing Page Curl snapshots, Cover decks, Scroll viewport anchors, and Webtoon offsets remain responsible for presentation restoration.
Validation
swift-formatswiftc -parse KMReader/Features/Reader/ViewModels/ReaderViewModel.swiftgit diff --checkmake build(iOS, macOS, and tvOS)