fix(reader): stop PDF overlay toggle glitches on iPadOS 18 - #963
Merged
Conversation
Two native PDF reader fixes: - Lock PDFView internal scroll views to contentInsetAdjustmentBehavior .never, re-applied after every presentation configuration change since usePageViewController rebuilds the hierarchy. The status bar toggling with the controls overlay otherwise shifts the page vertically through .automatic inset adjustment on iOS 18 (issue #956). - Reject single taps that moved more than 10pt or lasted over 0.5s, so slow/short accidental drags no longer toggle the reader overlays (issue #957).
everpcpc
marked this pull request as ready for review
August 22, 2026 14:33
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes two native PDF reader issues reported on iPadOS 18 (also observable on iOS 26 for the tap issue): #956 (page content shifts vertically whenever the controls overlay is shown or hidden) and #957 (slow/short drag gestures incorrectly toggle the controls overlay).
Changes
Both changes are in
PdfDocumentView_iOS:.statusBarHidden(!shouldShowControls)), which changes safe-area insets; PDFView's internal scroll views use.automaticcontent-inset adjustment, so the rendered page shifts vertically. All internal scroll views are now locked to.never, re-applied after every presentation configuration change becauseusePageViewController(_:)rebuilds PDFView's internal hierarchy.UITapGestureRecognizer's built-in movement slop lets slow/short drags through as taps. The coordinator now records the touch-down location and timestamp and rejects recognized "taps" that moved more than 10 pt or lasted longer than 0.5 s, so incidental contact while reading no longer pops the overlays.Validation
make build-ios/make build-macos/make build-tvosall pass.PdfDocumentViewand is untouched. Not verified on a physical iPadOS 18 device — feedback from the reporter on the next build would confirm.