✨ auditor: support non-collateral markets

[patitonar]

Summary by CodeRabbit

• New Features

  • Added support for listed markets that cannot be used as collateral.
  • Administrators can designate or update a market’s collateral eligibility.
  • Added configuration support for marking markets as non-collateral.
  • Non-collateral markets are excluded from collateral, liquidity, liquidation, and bad-debt calculations.

• Bug Fixes

  • Updated previews and health-factor calculations to accurately reflect non-collateral markets.
  • Prevented non-collateral markets from being incorrectly reported as collateral.

• Tests

  • Added comprehensive coverage for borrowing, withdrawals, liquidations, upgrades, and preview behavior.

[changeset-bot]

🦋 Changeset detected

Latest commit: d4a2b81

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@exactly/protocol	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: eaf98c2c-7ba8-463d-97b0-6051b37efbab

📥 Commits

Reviewing files that changed from the base of the PR and between 9fd6a42 and d4a2b81.

📒 Files selected for processing (3)

• .gas-snapshot
• deploy/Markets.ts
• test/AuditorUpgrade.t.sol

---

Walkthrough

Auditor now supports listed markets that cannot provide collateral. The status affects market entry, liquidity, withdrawal, liquidation, bad-debt handling, periphery previews, deployment configuration, upgrades, and protocol tests.

Changes

Auditor collateral rules

Layer / File(s)	Summary
Market status and collateral accounting contracts/Auditor.sol, test/Auditor.t.sol, test/Protocol.t.sol, .changeset/brave-otter-glides.md	MarketData stores nonCollateral. Admins can set it during market enablement or through setNonCollateral. Collateral, entry, liquidation, and bad-debt checks apply the flag.
Periphery previews and deployment wiring contracts/periphery/*, deploy/Markets.ts, hardhat.config.ts, test/*Previewer.t.sol, test/DebtManager.t.sol	Preview calculations exclude non-collateral markets from collateral totals while retaining debt effects. Deployment configuration passes and synchronizes the flag.
Upgrade compatibility test/AuditorUpgrade.t.sol, test/hardhat/1_auditor.ts	Upgrade tests verify state preservation, legacy market getter decoding, non-collateral toggling, market operations, and firewall behavior.
Market and verified-account flows test/Market.t.sol, test/VerifiedMarket.t.sol	Tests cover non-collateral deposits, borrowing, withdrawals, liquidation, bad debt, locking, and debt socialization.

Estimated code review effort: 5 (Critical) | ~120 minutes

Sequence Diagram(s)

sequenceDiagram
  participant Admin
  participant Auditor
  participant Previewer
  participant Market
  Admin->>Auditor: setNonCollateral(market, true)
  Market->>Auditor: request liquidity or liquidation check
  Auditor->>Auditor: exclude market collateral and retain debt
  Previewer->>Auditor: read market metadata
  Auditor-->>Previewer: return nonCollateral status
  Previewer-->>Market: return adjusted preview

Loading

Suggested reviewers: cruzdanilo, itofarina

🚥 Pre-merge checks | ✅ 4

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the main change: adding support for non-collateral markets in Auditor.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch non-collateral-markets

✨ Simplify code

• Create PR with simplified code
• Commit simplified code in branch non-collateral-markets

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 2

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

test/Protocol.t.sol (1)

630-641: 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

Load metadata for collateralMarket.

Line 636 loads metadata for market again. Lines 637-641 value collateralMarket's balance. If the markets use different decimals or adjust factors, the bad-debt assertion calculates incorrect adjusted collateral.

Proposed fix

-      (b.adjustFactor, b.decimals, , , , ) = auditor.markets(market);
+      (b.adjustFactor, b.decimals, , , , ) = auditor.markets(collateralMarket);

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 782541f2-ee53-44a7-9913-bbf7b6db3376

📥 Commits

Reviewing files that changed from the base of the PR and between 695096d and 9fd6a42.

📒 Files selected for processing (28)

• .changeset/brave-otter-glides.md
• .gas-snapshot
• contracts/Auditor.sol
• contracts/periphery/DebtManager.sol
• contracts/periphery/DebtPreviewer.sol
• contracts/periphery/DebtRoller.sol
• contracts/periphery/InstallmentsRouter.sol
• contracts/periphery/IntegrationPreviewer.sol
• contracts/periphery/Previewer.sol
• deploy/Markets.ts
• hardhat.config.ts
• test/Auditor.t.sol
• test/AuditorUpgrade.t.sol
• test/DebtManager.t.sol
• test/DebtPreviewer.t.sol
• test/DebtRoller.t.sol
• test/InstallmentsRouter.t.sol
• test/IntegrationPreviewer.t.sol
• test/Market.t.sol
• test/Pauser.t.sol
• test/Previewer.t.sol
• test/Protocol.t.sol
• test/RewardsController.t.sol
• test/VerifiedMarket.t.sol
• test/hardhat/0_admin.ts
• test/hardhat/1_auditor.ts
• test/hardhat/defaultEnv.ts
• test/hardhat/marketEnv.ts

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9fd6a4276d

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d4a2b81e02

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

[codecov]

Codecov Report

❌ Patch coverage is 96.77419% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 94.79%. Comparing base (695096d) to head (d4a2b81).

Files with missing lines	Patch %	Lines
contracts/periphery/DebtPreviewer.sol	93.75%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #815      +/-   ##
==========================================
- Coverage   94.82%   94.79%   -0.04%     
==========================================
  Files          31       31              
  Lines        2724     2746      +22     
  Branches      457      370      -87     
==========================================
+ Hits         2583     2603      +20     
- Misses        140      142       +2     
  Partials        1        1              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.