chore: drop the PyPI publishing scaffolding - #21
Open
emmanuel-defreitas wants to merge 1 commit into
Open
Conversation
corpora-docs is a documentation site. It has no pyproject.toml and ships no
Python package, but publish.yml still fires on every v* tag and tries to build
a wheel and publish it to PyPI as corpora-py — a different repo's package.
That is not dormant. release.yml pushes the release tag with an App token
specifically so downstream tag workflows fire ("everything downstream hangs off
the tag"), so the first release cut from this repo would have run it.
Removes publish.yml and the two composite actions only it used. Keeps
.github/actions/setup, which release.yml still needs. Also drops the pip
dependabot ecosystem, which has no manifests to scan here.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisite for releasing v0.2.0.
Problem
publish.ymlfires onpush: tags: v*and tries to build a Python wheel and publish it to PyPI under thecorpora-pyname — a different repo's package. This repo has nopyproject.tomland ships no Python package; it's leftoverrepo-templatescaffolding.This is not harmlessly dormant.
release.ymlpushes the release tag with an App token specifically so downstream tag workflows fire — its own comment says "everything downstream hangs off the tag ... events raised by GITHUB_TOKEN do not start workflow runs — so the tag MUST be created with [the App token]". The first release cut from this repo would have triggered it.Nothing had ever cut a release here before, which is why it went unnoticed:
mainaccepted direct pushes until the guard was activated in #18.Change
.github/workflows/publish.yml.github/actions/build-dist/and.github/actions/publish-pypi/— used by nothing else (verified across all workflows).github/actions/setup/—release.ymlstill uses itpipdependabot ecosystem; there are no Python manifests here to scanmake cipasses (25 pages validated).Note on the branch model
Targeting
release/v0.2.0rather thanmain, per the model activated in #18. This is the first change to go through it.