chore(dev): disable the first-run wizard in the docker dev stack - #89
Merged
Conversation
The first-run wizard opens a full-page modal on first login. In the dev container this is pure noise, and it breaks automated checks: it covers the content iframe, which the external-media host reads as obscured and hides every promoted player behind it.
Contributor
Preview this PR in the Nextcloud Playground
A fresh Nextcloud boots in your browser with this branch's eXeLearning editor: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Nextcloud's first-run wizard opens a full-page modal on a user's first
login. In the
make updev container this fires on every fresh stack,and it's pure noise for local development — but it's worse than noise
for automated checks: the modal sits on top of the content iframe, and
the external-media host correctly treats an obscured iframe as hidden,
so it hides every promoted player behind the wizard until it's
dismissed.
Fix
After
occ app:enable exelearningin theuptarget, also runocc app:disable firstrunwizard, tolerant of failure (|| true) so aNextcloud image that ships without that app (or that already has it
disabled) does not break the rest of the target.
Testing
No Docker daemon available in the environment used to prepare this
change, so validation was static:
make).make -n updry-run parses cleanly and expands the new lines in theright place, right after enabling the app, without disturbing the
rest of the target.