Make phpcs actually scan the plugin, and remove an orphan class

.github/workflows/ci.yml

@@ -116,6 +116,21 @@ jobs:
       - name: Run code linting (PHPCS)
         run: ./vendor/bin/phpcs --standard=.phpcs.xml.dist -q .
 
+      # Regression guard for the uploads exclude-pattern: scan a copy of the
+      # tree nested under a wp-content/uploads/exelearning/ parent directory.
+      # An absolute-type pattern matches that checkout location itself and
+      # silently excludes every file (exit 0, zero files checked), so assert
+      # the nested copy is actually scanned. checkout-index, not git archive:
+      # .gitattributes export-ignores dotfiles, including .phpcs.xml.dist.
+      - name: PHPCS exclude-pattern regression guard
+        run: |
+          nested="${RUNNER_TEMP}/wp-content/uploads/exelearning/plugin"
+          mkdir -p "${nested}"
+          git checkout-index --all --prefix="${nested}/"
+          checked=$(./vendor/bin/phpcs --standard="${nested}/.phpcs.xml.dist" --report=json -q "${nested}" | jq '.files | length')
+          echo "PHPCS checked ${checked} file(s) in the nested checkout"
+          test "${checked}" -gt 0
+
       # === JS UNIT TESTS (no WordPress runtime needed; fail fast before wp-env) ===
       - name: Run JavaScript unit tests
         run: npm run test:js

.phpcs.xml.dist

@@ -9,7 +9,12 @@
     <exclude-pattern>/tests/*</exclude-pattern>
     <exclude-pattern>/includes/vendor/*</exclude-pattern>
     <exclude-pattern>/dist/*</exclude-pattern>
-    <exclude-pattern>/exelearning/*</exclude-pattern>
+    <!-- Only the WordPress uploads extraction dir. type="relative" matches
+         against the path inside the scanned directory, never the checkout's
+         own filesystem location: an absolute-type pattern (the default) would
+         exclude the whole plugin when the checkout itself lives under a
+         matching path, e.g. /srv/wp-content/uploads/exelearning/plugin/. -->
+    <exclude-pattern type="relative">^wp-content/uploads/exelearning/*</exclude-pattern>
     <!-- Standalone developer CLI tooling; not shipped (see .distignore). -->
     <exclude-pattern>/bin/*</exclude-pattern>
 

languages/exelearning-ca.po

@@ -43,7 +43,6 @@ msgid "https://exelearning.net/"
 msgstr "https://exelearning.net/"
 
 #: admin/class-admin-settings.php:72
-#: public/views/elp-list.php:63
 #: assets/js/elp-upload.js:403
 msgid "Settings"
 msgstr "Configuració"
@@ -820,14 +819,6 @@ msgstr "Carrega el contingut interactiu"
 msgid "Download source file"
 msgstr "Descarrega el fitxer font"
 
-#: public/views/elp-list.php:112
-msgid "Select eXeLearning File"
-msgstr "Selecciona un fitxer eXeLearning"
-
-#: public/views/elp-list.php:113
-msgid "Use this file"
-msgstr "Utilitza aquest fitxer"
-
 #: assets/js/elp-upload.js:37
 msgid "Web (_web.zip)"
 msgstr "Web (_web.zip)"

languages/exelearning-ca_valencia.po

@@ -43,7 +43,6 @@ msgid "https://exelearning.net/"
 msgstr "https://exelearning.net/"
 
 #: admin/class-admin-settings.php:72
-#: public/views/elp-list.php:63
 #: assets/js/elp-upload.js:403
 msgid "Settings"
 msgstr "Configuració"
@@ -820,14 +819,6 @@ msgstr "Carrega el contingut interactiu"
 msgid "Download source file"
 msgstr "Descarregar el fitxer font"
 
-#: public/views/elp-list.php:112
-msgid "Select eXeLearning File"
-msgstr "Seleccionar un fitxer eXeLearning"
-
-#: public/views/elp-list.php:113
-msgid "Use this file"
-msgstr "Utilitzar este fitxer"
-
 #: assets/js/elp-upload.js:37
 msgid "Web (_web.zip)"
 msgstr "Web (_web.zip)"

languages/exelearning-de_DE.po

@@ -43,7 +43,6 @@ msgid "https://exelearning.net/"
 msgstr "https://exelearning.net/"
 
 #: admin/class-admin-settings.php:72
-#: public/views/elp-list.php:63
 #: assets/js/elp-upload.js:403
 msgid "Settings"
 msgstr "Einstellungen"
@@ -820,14 +819,6 @@ msgstr "Interaktive Inhalte laden"
 msgid "Download source file"
 msgstr "Quelldatei herunterladen"
 
-#: public/views/elp-list.php:112
-msgid "Select eXeLearning File"
-msgstr "eXeLearning-Datei auswählen"
-
-#: public/views/elp-list.php:113
-msgid "Use this file"
-msgstr "Diese Datei verwenden"
-
 #: assets/js/elp-upload.js:37
 msgid "Web (_web.zip)"
 msgstr "Web (_web.zip)"

languages/exelearning-eo.po

@@ -43,7 +43,6 @@ msgid "https://exelearning.net/"
 msgstr "https://exelearning.net/"
 
 #: admin/class-admin-settings.php:72
-#: public/views/elp-list.php:63
 #: assets/js/elp-upload.js:403
 msgid "Settings"
 msgstr "Agordoj"
@@ -820,14 +819,6 @@ msgstr "Ŝargi interagan enhavon"
 msgid "Download source file"
 msgstr "Elŝuti fontdosieron"
 
-#: public/views/elp-list.php:112
-msgid "Select eXeLearning File"
-msgstr "Elekti eXeLearning-dosieron"
-
-#: public/views/elp-list.php:113
-msgid "Use this file"
-msgstr "Uzi ĉi tiun dosieron"
-
 #: assets/js/elp-upload.js:37
 msgid "Web (_web.zip)"
 msgstr "Web (_web.zip)"

languages/exelearning-es_ES.po

@@ -43,7 +43,6 @@ msgid "https://exelearning.net/"
 msgstr "https://exelearning.net/"
 
 #: admin/class-admin-settings.php:72
-#: public/views/elp-list.php:63
 #: assets/js/elp-upload.js:403
 msgid "Settings"
 msgstr "Ajustes"
@@ -820,14 +819,6 @@ msgstr "Cargar contenido interactivo"
 msgid "Download source file"
 msgstr "Descargar archivo fuente"
 
-#: public/views/elp-list.php:112
-msgid "Select eXeLearning File"
-msgstr "Seleccionar archivo eXeLearning"
-
-#: public/views/elp-list.php:113
-msgid "Use this file"
-msgstr "Usar este archivo"
-
 #: assets/js/elp-upload.js:37
 msgid "Web (_web.zip)"
 msgstr "Web (_web.zip)"

languages/exelearning-eu.po

@@ -43,7 +43,6 @@ msgid "https://exelearning.net/"
 msgstr "https://exelearning.net/"
 
 #: admin/class-admin-settings.php:72
-#: public/views/elp-list.php:63
 #: assets/js/elp-upload.js:403
 msgid "Settings"
 msgstr "Ezarpenak"
@@ -820,14 +819,6 @@ msgstr "Kargatu eduki interaktiboa"
 msgid "Download source file"
 msgstr "Deskargatu iturburu fitxategia"
 
-#: public/views/elp-list.php:112
-msgid "Select eXeLearning File"
-msgstr "Hautatu eXeLearning fitxategia"
-
-#: public/views/elp-list.php:113
-msgid "Use this file"
-msgstr "Erabili fitxategi hau"
-
 #: assets/js/elp-upload.js:37
 msgid "Web (_web.zip)"
 msgstr "Web (_web.zip)"

languages/exelearning-gl_ES.po

@@ -43,7 +43,6 @@ msgid "https://exelearning.net/"
 msgstr "https://exelearning.net/"
 
 #: admin/class-admin-settings.php:72
-#: public/views/elp-list.php:63
 #: assets/js/elp-upload.js:403
 msgid "Settings"
 msgstr "Axustes"
@@ -820,14 +819,6 @@ msgstr "Cargar contido interactivo"
 msgid "Download source file"
 msgstr "Descargar ficheiro fonte"
 
-#: public/views/elp-list.php:112
-msgid "Select eXeLearning File"
-msgstr "Seleccionar ficheiro eXeLearning"
-
-#: public/views/elp-list.php:113
-msgid "Use this file"
-msgstr "Usar este ficheiro"
-
 #: assets/js/elp-upload.js:37
 msgid "Web (_web.zip)"
 msgstr "Web (_web.zip)"

languages/exelearning-it_IT.po

@@ -43,7 +43,6 @@ msgid "https://exelearning.net/"
 msgstr "https://exelearning.net/"
 
 #: admin/class-admin-settings.php:72
-#: public/views/elp-list.php:63
 #: assets/js/elp-upload.js:403
 msgid "Settings"
 msgstr "Impostazioni"
@@ -820,14 +819,6 @@ msgstr "Carica contenuto interattivo"
 msgid "Download source file"
 msgstr "Scarica file sorgente"
 
-#: public/views/elp-list.php:112
-msgid "Select eXeLearning File"
-msgstr "Seleziona file eXeLearning"
-
-#: public/views/elp-list.php:113
-msgid "Use this file"
-msgstr "Usa questo file"
-
 #: assets/js/elp-upload.js:37
 msgid "Web (_web.zip)"
 msgstr "Web (_web.zip)"

languages/exelearning-pt_PT.po

@@ -43,7 +43,6 @@ msgid "https://exelearning.net/"
 msgstr "https://exelearning.net/"
 
 #: admin/class-admin-settings.php:72
-#: public/views/elp-list.php:63
 #: assets/js/elp-upload.js:403
 msgid "Settings"
 msgstr "Definições"
@@ -820,14 +819,6 @@ msgstr "Carregar conteúdo interativo"
 msgid "Download source file"
 msgstr "Descarregar ficheiro fonte"
 
-#: public/views/elp-list.php:112
-msgid "Select eXeLearning File"
-msgstr "Selecionar ficheiro eXeLearning"
-
-#: public/views/elp-list.php:113
-msgid "Use this file"
-msgstr "Usar este ficheiro"
-
 #: assets/js/elp-upload.js:37
 msgid "Web (_web.zip)"
 msgstr "Web (_web.zip)"

languages/exelearning-ro_RO.po

@@ -43,7 +43,6 @@ msgid "https://exelearning.net/"
 msgstr "https://exelearning.net/"
 
 #: admin/class-admin-settings.php:72
-#: public/views/elp-list.php:63
 #: assets/js/elp-upload.js:403
 msgid "Settings"
 msgstr "Setări"
@@ -824,14 +823,6 @@ msgstr "Încarcă conținut interactiv"
 msgid "Download source file"
 msgstr "Descarcă fișierul sursă"
 
-#: public/views/elp-list.php:112
-msgid "Select eXeLearning File"
-msgstr "Selectează fișierul eXeLearning"
-
-#: public/views/elp-list.php:113
-msgid "Use this file"
-msgstr "Folosește acest fișier"
-
 #: assets/js/elp-upload.js:37
 msgid "Web (_web.zip)"
 msgstr "Web (_web.zip)"

languages/exelearning.pot

@@ -42,7 +42,6 @@ msgid "https://exelearning.net/"
 msgstr ""
 
 #: admin/class-admin-settings.php:72
-#: public/views/elp-list.php:63
 #: assets/js/elp-upload.js:403
 msgid "Settings"
 msgstr ""
@@ -819,14 +818,6 @@ msgstr ""
 msgid "Download source file"
 msgstr ""
 
-#: public/views/elp-list.php:112
-msgid "Select eXeLearning File"
-msgstr ""
-
-#: public/views/elp-list.php:113
-msgid "Use this file"
-msgstr ""
-
 #: assets/js/elp-upload.js:37
 msgid "Web (_web.zip)"
 msgstr ""

phpunit.xml.dist

@@ -17,8 +17,6 @@
       <directory>admin/vendor</directory>
       <!-- Excluded: has exit() statements and $_FILES dependencies -->
       <file>admin/class-admin-upload.php</file>
-      <!-- Excluded: requires non-existent file dependency -->
-      <file>public/views/elp-list.php</file>
       <!-- Excluded: only loaded under WP-CLI, which is unavailable to PHPUnit -->
       <file>includes/class-cli-command.php</file>
     </exclude>