Conversation
Contributor
|
Am I right to assume that you still work ok that, until all tests are green? |
Author
|
I think the test is only red because of the dependent PRs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Runs
bin/run.shin the browser on the wasm kernel, as jq-test-runner does.exercism_parseris compiled in GHA inside the kernel by the sysroot's clang, linked without--export-alland run throughwasm-opt(55KB, reproducible).bin/build-clientside-parser.shdoes this.Publish runs the suite in the kernel against the exact tarball it uploads.
run-in-kernel.mjsgains--extract, supportsprecompileand the canvas handlers newer kernels require.bin/run-tests.shnow fails when results differ ($?was read afterrm), and compares build errors by status only, since GCC and clang word them differently.helpers.hdropsstd::ptr_fun(removed in C++17, absent from libc++).example-tbbandlibtbb-devare removed.The workflows fetch with
curl --compressed(artifacts are stored brotli-encoded), andrun-in-kernel.mjspasses the kernel's fetches of stubbed binaries (/test-runners/...overlay/...) through to exercism.org, so CI runs on exactly what students get.The client-side check needs exercism/clientside-tooling#3 merged and published first.
Closes #104
Merge order
precompile.cpp/latest.json, so it merges last.