Add CMake option to skip monolithic library build - #2674
Open
NITIN9181 wants to merge 1 commit into
Open
Conversation
…#2593) Provides an option to skip the assembly of the monolithic libfolly, and instead exposes an INTERFACE target named 'folly' that aggregates all the granular component targets.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #2593
Summary
This PR adds a
FOLLY_BUILD_MONOLITHICCMake option (defaulting toONto preserve backward compatibility). When toggledOFF, the build system skips the assembly of the monolithiclibfolly.a/libfolly.solibrary.Instead, it creates an
INTERFACEtarget namedfollythat aggregates all of the granular component targets (e.g.,folly_io_iobuf). This ensures that downstream consumers callingtarget_link_libraries(... folly)continue to work without any changes, while significantly speeding up build and link times for projects that only need specific components.Changes
FOLLY_BUILD_MONOLITHICoption toCMakeLists.txtfolly_add_libraryinCMake/FollyFunctions.cmaketo track all granular targets.folly_create_monolithic_libraryto create anINTERFACEtarget when the option is disabled, bridging the granular targets and external dependencies.