Conversation
meta-cla
Bot
added
the
CLA Signed
Contributor
|
@ESoapW has exported this pull request. If you are a Meta employee, you can view the originating Diff in D120340800. |
Summary: OSS-Fuzz compiles the file holding a fuzz target as a non-test file, so it cannot see declarations in other _test.go files. FuzzCompute shared leaphash_test.go with three tests that use testDoc from testdata_test.go, so the CIFuzz build fails: leaphash/leaphash_test.go_fuzz.go:13:30: undefined: testDoc Move FuzzCompute to its own file. The converted file then references only Compute, and leaphash_test.go is free to grow without breaking the fuzz build. oss-fuzz's build.sh currently seds out one such test to work around this, which only holds until the next one is added. Differential Revision: D120340800
meta-codesync
Bot
changed the title
ESoapW
force-pushed
the
export-D120340800
branch
from
September 16, 2026 12:32
03ccb0d to
80c7905
Compare
Contributor
|
This pull request has been merged in 7150732. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
OSS-Fuzz compiles the file holding a fuzz target as a non-test file, so it cannot
see declarations in other _test.go files. FuzzCompute shared leaphash_test.go with
three tests that use testDoc from testdata_test.go, so the CIFuzz build fails:
leaphash/leaphash_test.go_fuzz.go:13:30: undefined: testDoc
Move FuzzCompute to its own file. The converted file then references only Compute,
and leaphash_test.go is free to grow without breaking the fuzz build.
oss-fuzz's build.sh currently seds out one such test to work around this, which only
holds until the next one is added.
Differential Revision: D120340800