Add SET DEFAULT and NO ACTION to OnDeleteType#2034
Open
anxkhn wants to merge 1 commit into
Open
Conversation
The OnDeleteType literal that types Field(ondelete=...) only listed CASCADE, SET NULL and RESTRICT, so type checkers rejected the other two standard SQL referential actions, SET DEFAULT and NO ACTION, even though both are valid at runtime and emit correct ON DELETE DDL via SQLAlchemy. Add the two missing actions to the literal and cover them with a parametrized regression test asserting the generated foreign key and DDL.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The only workarounds were casting to
Anyor dropping down tosa_column.NO ACTIONis the default referential action in PostgreSQL and most databases,and
SET DEFAULTpairs naturally with a columnserver_default, so both arethings people legitimately want to spell out.
This adds the two missing actions to
OnDeleteType. There is no runtime change(the value was always passed through unchanged); this only corrects the static
type. Reported in #1839.
Tests
Added a parametrized regression test over the two newly typed actions that
asserts both the resulting foreign key's
ondeleteand the generatedON DELETE <action>DDL, mirroring the existingtest_foreign_key_ondelete_with_annotated.AI Disclaimer
AI used for diagnostics and drafting; the change and test were reviewed by hand.