refactor(benchmark-results): emit numeric values instead of strings - #465
Open
ilteoood wants to merge 1 commit into
Open
refactor(benchmark-results): emit numeric values instead of strings#465ilteoood wants to merge 1 commit into
ilteoood wants to merge 1 commit into
Conversation
The output JSON now stores requests, latency, and throughput as numbers (null for missing values) using the same decimal precision as before, unblocking consumers that rely on numeric JSON.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The committed
benchmark-results.jsonand the file produced bybenchmark-compare.jshadrequests,latency, andthroughputencoded as strings (e.g.
"54500.8") and"N/A"for missingvalues. Numeric JSON consumers can't operate on those directly.
This change emits them as numbers (using
Math.roundwith the samedecimal precision as before) and
nullwhen a metric is absent,while keeping the rounding behaviour identical for present values.
benchmark-results.jsonis regenerated to match so the checked-infile stays consistent with the new format.