Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion index.js
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,7 @@ function fastifyWebsocket (fastify, opts, next) {
}
}

fastify.server.removeListener('upgrade', onUpgrade)
websocketListenServer.removeListener('upgrade', onUpgrade)

server.close(done)

Expand Down
18 changes: 18 additions & 0 deletions test/base.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -352,6 +352,24 @@ test('Should be able to pass a custom server option to ws', async (t) => {
ws.close()
})

test('Should remove the upgrade listener from a custom server on close', async (t) => {
const externalServer = http.createServer()
t.after(() => externalServer.close())
await new Promise((resolve, reject) => {
externalServer.once('error', reject)
externalServer.listen(0, resolve)
})

const fastify = Fastify()
t.after(() => fastify.close())
await fastify.register(fastifyWebsocket, { options: { server: externalServer } })
await fastify.ready()

t.assert.strictEqual(externalServer.listenerCount('upgrade'), 1)
await fastify.close()
t.assert.strictEqual(externalServer.listenerCount('upgrade'), 0)
})

test('Should be able to pass clientTracking option in false to ws', async (t) => {
const fastify = Fastify()

Expand Down
Loading