Release/v0.7.2 - #60
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release v0.7.2
Bug Fixes
Preserve incomplete elements across stream chunks — Fixed a bug in
process_streamwhere HTML or ESI tags span across chunk boundaries were silently dropped. This is especially visible with smaller chunk sizes. When the streaming parser returnedIncomplete, the unconsumed bytes were lost because the split buffer was empty; now the incomplete input is preserved so the next iteration can append to it and retry parsing. Similarly, the recoverable parse-error path also now correctly passes through thefrozenbytes instead of the already-clearedbuffer. Thanks @prk-Jr for the report and the fix! (4c53fea)Features
Add
<!--esi ...-->comment block parsing — Implemented support for ESI comment blocks per W3C ESI spec §3.7.<!--esi ...-->delimiters are now stripped and the inner content is parsed as ESI markup (e.g.<esi:include>,<esi:vars>). Regular HTML comments continue to pass through unchanged. Matching is case-sensitive (<!--ESI -->is treated as a regular comment). Thanks to @tomchappell for the report! (b61f8bf, 3ed3a71)Tests
<!--esi -->comment block unit tests covering includes, vars, plain HTML, streaming incomplete, case sensitivity, and regular comment passthrough