-
Notifications
You must be signed in to change notification settings - Fork 1
benchmark comparison code and report #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| { | ||
| "yaml.customTags": [ | ||
| "tag:yaml.org,2002:python/name:pymdownx.superfences.fence_code_format scalar" | ||
| ] | ||
| } |
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,119 @@ | ||||||||||
| # Benchmarks: OHDSI R Packages vs OMOPy | ||||||||||
|
|
||||||||||
| This directory contains a benchmark suite that runs identical analyses | ||||||||||
| using both the OHDSI R packages and OMOPy (Python), then compares the | ||||||||||
| results. | ||||||||||
|
|
||||||||||
| ## Prerequisites | ||||||||||
|
|
||||||||||
| - **Python** with OMOPy installed (`uv sync`) | ||||||||||
| - **R** 4.5+ available on `PATH` | ||||||||||
|
|
||||||||||
| ## Quick Start | ||||||||||
|
|
||||||||||
| ```bash | ||||||||||
| # 1. Install R packages (one-time) | ||||||||||
| Rscript benchmarks/r/install_packages.R | ||||||||||
|
|
||||||||||
| # 2. Generate the 10K-patient test database (one-time, ~800MB download) | ||||||||||
| Rscript benchmarks/generate_synthea_1k.R | ||||||||||
|
|
||||||||||
| # 3. Run R benchmarks | ||||||||||
| Rscript benchmarks/r/run_all.R | ||||||||||
|
|
||||||||||
| # 4. Run Python benchmarks | ||||||||||
| python benchmarks/python/run_all.py | ||||||||||
|
|
||||||||||
| # 5. Generate comparison report | ||||||||||
| python benchmarks/compare.py | ||||||||||
| ``` | ||||||||||
|
|
||||||||||
| The comparison report is written to `docs/comparison.md` and appears in | ||||||||||
| the mkdocs site under **Project → R vs Python Comparison**. | ||||||||||
|
Comment on lines
+31
to
+32
|
||||||||||
| The comparison report is written to `docs/comparison.md` and appears in | |
| the mkdocs site under **Project → R vs Python Comparison**. | |
| The comparison report is written to `docs/comparison.md` and can be | |
| included in the mkdocs site if that page is added to the navigation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The prerequisites list says Java 11+ is required for Synthea data generation, but
benchmarks/generate_synthea_1k.Rdownloads a pre-built Eunomia dataset and doesn’t invoke Synthea/Java. Please update the prerequisites (and any other references) so users don’t install Java unnecessarily.