Add rotation and contextMenu UI control options - #138
Merged
Conversation
The Felt app recently gained embed URL params to disable map rotation and the right-click menu (felt/felt#21372). Expose them through the SDK: both options ride the existing UiControlsOptions schema, so they work in Felt.embed (as URL params) and updateUiControls (handled by the app's existing assign-through handler). Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
corbinmuraro
force-pushed
the
corbin/embed-rotation-context-menu-controls
branch
from
August 20, 2026 22:22
8bf6b23 to
7a47c16
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exposes the embed controls introduced in felt/felt#21372 through the SDK:
rotationandcontextMenujoinUiControlsOptions, so they can be set at embed time viaFelt.embed(mapped to therotation/contextMenuURL params) and toggled at runtime viaupdateUiControls.No app-side handler change is needed —
updateUiControlsalready assigns params ontocontrolsVisibilityState, which reacts to both keys — but the app's pinned@feltmaps/js-sdkwill need bumping to a version containing this once released, so the handler's schema stops stripping the new keys.