Clean the implementation of temperature_or_pressure arguments somewhat - #369
Merged
Conversation
prehner
force-pushed
the
temperature_pressure_cleanup
branch
3 times, most recently
from
July 24, 2026 08:50
f0292a5 to
e778017
Compare
prehner
force-pushed
the
temperature_pressure_cleanup
branch
from
July 24, 2026 08:56
e778017 to
118789e
Compare
g-bauer
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses theEitherenum from theeithercrate to have a more transparent flow of informationTemperatureOrPressureSpecificationenum to have a more transparent flow of informationf64instead ofDfor specifying initial values for algorithms (the derivative parts were never read anyways). Unfortunately this makes this a breaking change.