Write SED FITS norm_ul at the configured ul_confidence - #682
Open
shaneraphel wants to merge 1 commit into
Open
shaneraphel wants to merge 1 commit into
shaneraphel wants to merge 1 commit into
Conversation
_make_sed already fills norm_ul at ul_confidence and dnde_ul already uses that occupancy. The FITS writer still stored norm_ul95 under the norm_ul column and hard-coded UL_CONF=0.95. Copy the configured values instead. The 95% scan is unchanged.
shaneraphel
force-pushed
the
sed-fits-ul-conf-673
branch
from
September 16, 2026 10:36
5c8f9df to
9dd6c53
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #673.
_make_sedalready fillsnorm_ulat the configuredul_confidence, and the FITSdnde_ulcolumn already writes that occupancy._make_sed_fitsstill storessed['norm_ul95']in the column namednorm_uland hard-codesUL_CONF=0.95. Wheneversed.ul_confidenceis not 0.95, the FITS product and its metadata do not match the configured limit.Unique rewrite:
The 95% scan (
norm_ul95) is not dropped.dnde_ulis not rewritten.Measured with astropy 8.0.1 on dummy one-bin SED dicts (
n_paired=3; not Fermi event data):ul_confidencenorm_ul/UL_CONF