feat!: add cause to blob release arguments - #50
Merged
Conversation
bajtos
approved these changes
Jul 29, 2026
bajtos
left a comment
Member
There was a problem hiding this comment.
I find it a bit weird that we are only adding a field to ReleaseArguments struct, with no behaviour changes. How can we verify that this is the right thing? Is there any downstream pull request showing how this new field will be used in our services?
Member
Author
|
So, Sprue makes this invocation. There is currently no code or PR to update. Here's the PR for Piri (targets @frrist's PR for adding removal functionality): fil-forge/piri#45 |
frrist
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A Piri storage node currently has no way to verify the legitimacy of a
/blob/releaseinvocation beyond trusting the upload service that issued it./blob/releaseis the upload service's translation of a client/blob/remove, so the fix is to make the release carry proof of that origin: a Cause field holding the CID of the/blob/removetask, with the remove invocation itself travelling as metadata in the request container. The node then verifies:/blob/removeinvocation identified byCauseis present in the request container,Space,Digest