[API-v3] Add tests for path traversal and invalid ID encoding methods - #277
Open
Orkuncakilkaya wants to merge 3 commits into
Open
[API-v3] Add tests for path traversal and invalid ID encoding methods#277Orkuncakilkaya wants to merge 3 commits into
Orkuncakilkaya wants to merge 3 commits into
Conversation
Contributor
|
🟢 Coverage increased by 34.33% Code Coverage ReportCoverage Report
Files Coverage
|
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The malformed-ID test matrix omits empty request IDs for updateEvent, and one test name misstates the tested behavior.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Adds regression tests for safely encoding malformed IDs in API path segments.
Changes:
- Tests serializer handling of traversal, URLs, slashes, and empty strings.
- Verifies request paths and hosts across fingerprint API methods.
File summaries
| File | Description |
|---|---|
test/ObjectSerializerTest.php |
Covers path-value encoding edge cases. |
test/FingerprintApiTest.php |
Covers malformed IDs in generated API requests. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 2
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Orkuncakilkaya
marked this pull request as ready for review
September 10, 2026 12:44
Orkuncakilkaya
requested review from
TheUnderScorer,
erayaydin and
ilfa
as code owners
September 10, 2026 12:44
…ent URL normalization issues
Contributor
🚀 Following releases will be created using changesets from this PR:fingerprint-pro-server-api-php-sdk@6.13.1Patch Changes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.