Skip to content

docs(kits): remove stale factory-pattern references #2930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cabljac wants to merge 1 commit into
base: kits
Choose a base branch
from
Open

docs(kits): remove stale factory-pattern references #2930

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions kits/firestore-incremental-capture/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,10 @@
* the same name.
*
* Skeleton package: not yet implemented. Target shape follows the
* firestore-bigquery-export reference package — a `define...` factory (tier 3)
* over injectable handlers (tier 2), with a side-effect-free `./lib` surface and
* this env-driven entry registering functions for the clone-and-deploy example.
* firestore-bigquery-export reference package — this entry wires triggers
* directly at module top level with deploy-time param expressions over
* injectable handlers, with a side-effect-free `./lib` surface for the
* handlers and config types.
*/

export {};
7 changes: 4 additions & 3 deletions kits/firestore-translate-text/SPEC.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,9 +66,10 @@ export const fstranslate: CloudFunction<FirestoreEvent<...>>;
1. Scaffold from reference; keep `events.ts`.
2. Port `translate/` modules; abstract the provider behind a small interface so
`google-translate` vs `gemini` is a typed switch.
3. Wire the secret via `defineSecret("GOOGLE_AI_API_KEY")`; pass into factory
`secrets`; read with `.value()` in the handler context. Document granting it
and **reusing the existing secret** on migration (don't re-enter).
3. Wire the secret via `defineSecret("GOOGLE_AI_API_KEY")`; pass it in the
trigger's `secrets` option; read with `.value()` in the handler context.
Document granting it and **reusing the existing secret** on migration
(don't re-enter).
4. Map params in `config.ts`; preserve update-detection (only translate when the
input field changed) and delete handling.
5. Register roles/APIs from `extension.yaml` in `index.ts`.
Expand Down
Loading