fix(bq-scripts): use full git URL in repository.url - #2967
Open
CorieW wants to merge 1 commit into
Open
Conversation
npm publish --provenance validates that package.json repository.url resolves to the GitHub repo building the package. Both BigQuery script packages declared a bare "github.com/firebase/extensions.git", which npm cannot parse into https://github.com/firebase/extensions, so provenance generation fails. Prefix both with "git+https://" to match the sibling firestore-bigquery-change-tracker package, which already publishes with provenance successfully.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
npm publish --provenancerequiresrepository.urlto resolve to the GitHub repo that built the package. Two BigQuery script packages declared a baregithub.com/firebase/extensions.git— no scheme, so npm can't normalise it and provenance fails.Prefixed both with
git+https://, matchingfirestore-bigquery-change-tracker, which already publishes fine:@firebaseextensions/fs-bq-schema-views@firebaseextensions/fs-bq-import-collectionBroken since
--provenancewas added in March 2026. No otherpackage.jsononnextis affected.