Skip to content

fix(bq-scripts): use full git URL in repository.url - #2967

Open
CorieW wants to merge 1 commit into
nextfrom
fix/provenance-repository-url
Open

fix(bq-scripts): use full git URL in repository.url#2967
CorieW wants to merge 1 commit into
nextfrom
fix/provenance-repository-url

Conversation

@CorieW

@CorieW CorieW commented Aug 21, 2026

Copy link
Copy Markdown
Member

Summary

npm publish --provenance requires repository.url to resolve to the GitHub repo that built the package. Two BigQuery script packages declared a bare github.com/firebase/extensions.git — no scheme, so npm can't normalise it and provenance fails.

Prefixed both with git+https://, matching firestore-bigquery-change-tracker, which already publishes fine:

  • @firebaseextensions/fs-bq-schema-views
  • @firebaseextensions/fs-bq-import-collection

Broken since --provenance was added in March 2026. No other package.json on next is affected.

npm publish --provenance validates that package.json repository.url
resolves to the GitHub repo building the package. Both BigQuery script
packages declared a bare "github.com/firebase/extensions.git", which
npm cannot parse into https://github.com/firebase/extensions, so
provenance generation fails.

Prefix both with "git+https://" to match the sibling
firestore-bigquery-change-tracker package, which already publishes
with provenance successfully.
@CorieW
CorieW requested a review from a team as a code owner August 21, 2026 11:05

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the repository URL protocol to 'git+https://' in the package.json files of the 'gen-schema-view' and 'import' scripts. No review comments were provided, and there is no further feedback to address.

@CorieW
CorieW requested a review from cabljac August 21, 2026 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants