Skip to content

[Messaging] Add new Registration methods - #1498

Open
a-maurice wants to merge 3 commits into
mainfrom
am-messaging_registration
Open

[Messaging] Add new Registration methods#1498
a-maurice wants to merge 3 commits into
mainfrom
am-messaging_registration

Conversation

@a-maurice

Copy link
Copy Markdown
Collaborator

Description

Provide details of the change, and generalize the change in the PR title above.

Adds support for the new Messaging registration method, which uses Installation Ids over the old FCM tokens. Note that it is not on by default, and requires setting the appropriate variable in the Android or iOS project. Note that this requires the equivalent changes to be submitted in the C++ repo first.


Testing

Describe how you've tested these changes.

https://github.com/firebase/firebase-unity-sdk/actions/runs/30405465237
And running the tests locally with both the old and new methods enabled.


Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces new Firebase Messaging registration methods using Installation IDs (FIDs) and deprecates the older token-based methods across the SDK, SWIG wrappers, and sample applications. The review feedback highlights critical safety improvements, specifically adding null checks for installation_id in the SWIG callbacks to prevent potential crashes, and adjusting the automated test logic to gracefully handle the new registration flow and avoid test flakiness.

Comment thread messaging/src/swig/messaging.i
Comment thread messaging/src/swig/messaging.i
@a-maurice
a-maurice requested a review from AustinBenoit July 29, 2026 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant