[Messaging] Add new Registration methods - #1498
Open
a-maurice wants to merge 3 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces new Firebase Messaging registration methods using Installation IDs (FIDs) and deprecates the older token-based methods across the SDK, SWIG wrappers, and sample applications. The review feedback highlights critical safety improvements, specifically adding null checks for installation_id in the SWIG callbacks to prevent potential crashes, and adjusting the automated test logic to gracefully handle the new registration flow and avoid test flakiness.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds support for the new Messaging registration method, which uses Installation Ids over the old FCM tokens. Note that it is not on by default, and requires setting the appropriate variable in the Android or iOS project. Note that this requires the equivalent changes to be submitted in the C++ repo first.
Testing
https://github.com/firebase/firebase-unity-sdk/actions/runs/30405465237
And running the tests locally with both the old and new methods enabled.
Type of Change
Place an
xthe applicable box: