RR-24: Clarify stopped-service recovery action - #41
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Why: - A configured host with brokerd stopped instructed people to start the service while its action misleadingly said Finish setup. Changed: - Centralize guided setup action labels by startup state. - Show Start service for configured stopped-service recovery while preserving restart-required and first-time setup wording. - Cover no-snapshot, read-only snapshot, incompatible-runtime, and missing-host boundaries and update the guided setup contract. Verification: - npm run test:app:focus -- SimulatorBrokerAppTests/BrokerDashboardStoreTests (92 tests). - npm run agent:verify -- --profile implementation (full app 172 tests plus routed suites). - npm run agent:verify -- --profile spec-only (51 public-front-door tests plus contract checks). - Current-source public-release scan and staged semantic diff review. Affected: - macOS dashboard and setup recovery copy only; guided setup and service-control semantics are unchanged. Refs: - RR-24 Session: - task-sessions/stopped-service-cta-alpha5.oTJqYc
1678a11 to
c018967
Compare
|
@codex review |
|
Codex Review: Didn't find any major issues. Another round soon, please! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Reviewed top-level PR feedback and left the current code unchanged. These items were posted as PR review bodies or conversation comments rather than unresolved review threads, so this acknowledgement is recorded on the PR timeline.
|
1 participant
Summary
Start servicewhen a configured host has stoppedbrokerdFinish setupfor verified runtime-restart recoveryComplete first-time setupwhen host configuration is genuinely missingFailure-discipline notes
RR-24 appeared from the interaction of valid existing configuration, transient service unavailability, and generic setup wording. The change centralizes the state-to-label mapping without adding another service-control path. Regression coverage separates configured service-down with and without a cached snapshot from incompatible-runtime restart and missing-host first-time setup.
Verification
npm run test:app:focus -- SimulatorBrokerAppTests/BrokerDashboardStoreTests— 92 tests passednpm run agent:verify -- --profile implementation— full routed suite passed, including 172 app testsnpm run agent:verify -- --profile spec-only— passed, including 51 public-front-door testsInstalled-app evidence
The exact-candidate stopped/recovered screenshot cycle is deferred because the Studio currently has an active operator lease. No controller, service, pin, lease, or install state was touched. The installed-app cycle will be run only after occupancy reaches zero, before the next release candidate is accepted.
Residual risk
The CTA still routes through the existing idempotent guided setup flow rather than a new direct-start mechanism. That preserves recovery safety but means the label describes the intended outcome, not a newly independent service API.