Skip to content

fix(project): reject newer panel schema, dedupe alignment ids, sync panel doc versions - #711

Merged
fixcik merged 1 commit into
masterfrom
fix/pr709-review-followup
Jul 17, 2026
Merged

fix(project): reject newer panel schema, dedupe alignment ids, sync panel doc versions#711
fixcik merged 1 commit into
masterfrom
fix/pr709-review-followup

Conversation

@fixcik

@fixcik fixcik commented Jul 17, 2026

Copy link
Copy Markdown
Owner

Фоллоуап по замечаниям CodeRabbit на PR #709 (Refs #709):

  • Миграции больше не понижают молча будущую схему панели: manifest_from_value и legacy-путь open_project отклоняют panel.schema_version новее поддерживаемой (гейт уровня манифеста уже был) — иначе перезапись контейнера теряла бы поля новой версии.
  • effective_alignment_points() без коллизий id: явная точка с id registration-отверстия отбрасывается (побеждает точка от отверстия) + тест.
  • UI: инлайновые PanelDoc-литералы в DesignPickerRow.tsx / AddDesignWindow.tsx несли устаревший schema_version: 3 — заменены хелпером newPanelDoc(); фикстуры тестов подняты до v5.
  • docs/PROJECT.md: вводный абзац про manifest.panel v4 → v5.

Проверки: cargo test -p cuprum-project (106 ok), cargo clippy --all-targets -D warnings, pnpm test (863 ok), pnpm build.

@fixcik
fixcik enabled auto-merge (squash) July 17, 2026 22:13
@coderabbitai

coderabbitai Bot commented Jul 17, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@fixcik, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 30 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: d5277269-d1fd-4a36-9661-9e2f18d8cd71

📥 Commits

Reviewing files that changed from the base of the PR and between 4ace1d8 and e52e926.

📒 Files selected for processing (8)
  • crates/cuprum-project/src/document/migrate.rs
  • crates/cuprum-project/src/document/panel.rs
  • crates/cuprum-project/src/lib.rs
  • cuprum-ui/src/components/project/DesignPickerRow.tsx
  • cuprum-ui/src/lib/exposeRequest.test.ts
  • cuprum-ui/src/lib/feasibility.test.ts
  • cuprum-ui/src/windows/AddDesignWindow.tsx
  • docs/PROJECT.md

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@fixcik
fixcik merged commit 1383180 into master Jul 17, 2026
4 checks passed
@fixcik
fixcik deleted the fix/pr709-review-followup branch July 17, 2026 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant