Skip to content

feat(drill): offer panel corners as capture points in the points wizard - #719

Merged
fixcik merged 1 commit into
masterfrom
feat/wizard-corner-points
Jul 18, 2026
Merged

feat(drill): offer panel corners as capture points in the points wizard#719
fixcik merged 1 commit into
masterfrom
feat/wizard-corner-points

Conversation

@fixcik

@fixcik fixcik commented Jul 18, 2026

Copy link
Copy Markdown
Owner

Refs #718

В мастере рабочего нуля «По точкам, вручную» (метод 2) в шаге 1 теперь предлагаются четыре угла платы как синтетические точки захвата (бэдж «угол», имена вида «Угол · Низ-лево»). Ноль можно привязать по двум голым углам без подготовки — без реперов и своих точек в редакторе панели. По умолчанию углы не выбраны (реальные точки точнее); «выбрать все» включает и их.

Следствие: карточка метода 2 в пикере больше не блокируется причиной «нет точек» (углы есть у любой панели) — причина noPoints и кнопка «Открыть редактор» удалены.

Технически: panelCornerPoints() / cornerOfPoint() в lib/alignmentPoints.ts (source "corner", ид corner:<угол>); нумерация точек углы пропускает; идеалы углов идут тем же конвейером buildFiducialEntriesmachinePoint. Тесты расширены.

@fixcik
fixcik enabled auto-merge (squash) July 18, 2026 15:41
@coderabbitai

coderabbitai Bot commented Jul 18, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@fixcik, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 34 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 4902cc65-90dc-4fd4-8be2-dd88e4c2cd07

📥 Commits

Reviewing files that changed from the base of the PR and between c22744e and 92968c4.

📒 Files selected for processing (9)
  • cuprum-ui/src/components/drill/DrillPlanInspector.tsx
  • cuprum-ui/src/components/drill/WorkZeroMethodPicker.tsx
  • cuprum-ui/src/components/drill/WorkZeroPointsWizard.tsx
  • cuprum-ui/src/lib/alignmentPoints.test.ts
  • cuprum-ui/src/lib/alignmentPoints.ts
  • cuprum-ui/src/lib/workZeroMethods.test.ts
  • cuprum-ui/src/lib/workZeroMethods.ts
  • cuprum-ui/src/locales/en/drill.json
  • cuprum-ui/src/locales/ru/drill.json

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@fixcik
fixcik merged commit d03d132 into master Jul 18, 2026
4 checks passed
@fixcik
fixcik deleted the feat/wizard-corner-points branch July 18, 2026 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant