Skip to content

fix(drill): undo fiducial registration when mapping head position to the map - #722

Merged
fixcik merged 1 commit into
masterfrom
fix/drill-marker-registration
Jul 18, 2026
Merged

fix(drill): undo fiducial registration when mapping head position to the map#722
fixcik merged 1 commit into
masterfrom
fix/drill-marker-registration

Conversation

@fixcik

@fixcik fixcik commented Jul 18, 2026

Copy link
Copy Markdown
Owner

Refs #721

После привязки нуля методом «По точкам, вручную» G-code компенсирует поворот/масштаб платы (registration применяется к координатам отверстий: work = s·R(θ)·ideal), а маркер головы на карте мапил WPos в панель чистым переносом — из-за этого он смещался относительно нарисованных отверстий, тем сильнее, чем дальше от нуля.

Фикс:

  • DrillPlanResult (cuprum-drill) теперь возвращает применённую регистрацию (эхо эффективного input.registration);
  • новый чистый undoRegistration() — обратное преобразование ideal = R(−θ)·WPos / s (+ юнит-тесты на round-trip);
  • DrillOperationEditor при старте прогона запоминает регистрацию плана и применяет обратное преобразование к позиции головы перед отрисовкой маркера. Без регистрации — как раньше (identity).

@fixcik
fixcik enabled auto-merge (squash) July 18, 2026 16:09
@coderabbitai

coderabbitai Bot commented Jul 18, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@fixcik, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 6 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: df8d175f-5599-430c-b17a-60ef0d39b495

📥 Commits

Reviewing files that changed from the base of the PR and between 99937d7 and ff867ac.

📒 Files selected for processing (5)
  • crates/cuprum-drill/src/plan.rs
  • cuprum-ui/src/components/operations/DrillOperationEditor.tsx
  • cuprum-ui/src/lib/api.ts
  • cuprum-ui/src/lib/fiducialRegistration.test.ts
  • cuprum-ui/src/lib/fiducialRegistration.ts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@fixcik
fixcik merged commit 66ffb00 into master Jul 18, 2026
4 checks passed
@fixcik
fixcik deleted the fix/drill-marker-registration branch July 18, 2026 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant