fix(drill): undo fiducial registration when mapping head position to the map - #722
Conversation
|
Warning Review limit reached
Next review available in: 6 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Refs #721
После привязки нуля методом «По точкам, вручную» G-code компенсирует поворот/масштаб платы (registration применяется к координатам отверстий:
work = s·R(θ)·ideal), а маркер головы на карте мапил WPos в панель чистым переносом — из-за этого он смещался относительно нарисованных отверстий, тем сильнее, чем дальше от нуля.Фикс:
DrillPlanResult(cuprum-drill) теперь возвращает применённую регистрацию (эхо эффективногоinput.registration);undoRegistration()— обратное преобразованиеideal = R(−θ)·WPos / s(+ юнит-тесты на round-trip);DrillOperationEditorпри старте прогона запоминает регистрацию плана и применяет обратное преобразование к позиции головы перед отрисовкой маркера. Без регистрации — как раньше (identity).