Release 0.1.1 - #7
Merged
Merged
Conversation
The upload<Variant>Sourcemaps task is a finalizer of the JS bundle task, so any failure inside it used to fail the whole release build and leave the APK unbuilt. The upload is now decoupled from the build result: - when FLASHCAT_API_KEY is not set the task is skipped (onlyIf) with a warning that names the key and the FLASHCAT_SOURCEMAPS_DRY_RUN escape hatch; dry run mode still runs the task since it does not need a key - a non-zero flashcat-cli exit (invalid key, network error, ...) is reported as a warning carrying the CLI stderr/stdout instead of failing the build The task still runs automatically after the bundle task, so existing CI setups keep working unchanged. The README documents the new behaviour.
fix(android): make sourcemap upload non-blocking for release builds
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Promote flashcat-maintenance to publish for the 0.1.1 release.
Changes since 0.1.0
FLASHCAT_API_KEYis not set.FLASHCAT_SOURCEMAPS_DRY_RUN=trueruns the task without a key and without uploading.All packages bumped to 0.1.1 in lockstep; no API changes.