chore(ci): security hardening - #1
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR hardens CI security by pinning third-party GitHub Actions to immutable commit SHAs and disabling persisted Git credentials in checkout steps, addressing reported zizmor findings (unpinned-uses, artipacked).
Changes:
- Pin
actions/checkoutanddart-lang/setup-dartto commit SHAs intest.yml, and disablepersist-credentials. - Pin
actions/checkout,dart-lang/setup-dart,oven-sh/setup-bun, andactions/upload-artifactto commit SHAs inbenchmark.yml, and disablepersist-credentials.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/test.yml | Pins checkout/setup-dart to SHAs and disables persisted credentials for safer CI execution. |
| .github/workflows/benchmark.yml | Pins all referenced actions to SHAs and disables persisted credentials; keeps artifact upload pinned as well. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes fluttercandies/security-scanner#26
Changes
Pins all third-party GitHub Actions to immutable commit SHAs and hardens credential handling, addressing zizmor findings (unpinned-uses, artipacked).
.github/workflows/benchmark.ymlactions/checkout,dart-lang/setup-dart,oven-sh/setup-bun, andactions/upload-artifactto commit SHAs.persist-credentials: falseto theactions/checkoutstep..github/workflows/test.ymlactions/checkoutanddart-lang/setup-dartto commit SHAs.persist-credentials: falseto theactions/checkoutstep.