chore(worktree): put worktrees under .claude and carry the overrides into them - #24
Conversation
…into them Worktrees used to sit beside the checkout as <repo>-<slug>, which put them in the workspace directory next to the real repositories and left EnterWorktree unusable, since that tool writes to a fixed .claude/worktrees/<slug>. Pattern proven on fluttersdk/magic_starter#124.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
Note Kodizm (AI-generated). May contain mistakes; verify before acting. Looks correct - two config files, no code paths touched, and the two ways this layout could leak into the package or the toolchain both check out clean. What I checked rather than assumed:
The absolute-path requirement for TestsNothing covers this and nothing should - the behaviour lives in Claude Code's worktree creation, not in this package. Checks I ran
|
|
Note Kodizm (AI-generated). May contain mistakes; verify before acting. Since my last review the only new commit is Minor
TestsNothing covers this and nothing should - it is a comment in an ignore file. Checks I ran
|
The comment claimed plain -xdf wipes a live worktree because its .git is a file rather than a directory. Measured on a scratch repo: the dry run prints "Skipping repository .claude/worktrees/slug", the worktree survives -xdf with its untracked files intact, and only -xdff removes it and leaves the registration prunable. The guard keys on the gitlink, not on the form of .git. Also splits the stray # that joined the two comment blocks.
|
You are right and I had it backwards. Reproduced your probe independently before changing anything: So the guard keys on the gitlink, exactly as you said, and my stated reason (that a file-form The stray |
|
Note Kodizm (AI-generated). May contain mistakes; verify before acting. One new commit since my last review, Re-probed rather than taking the corrected wording on trust (git 2.43.0, scratch repo, worktree at
The stray trailing Ignore behaviour is unchanged by the edit: TestsNothing covers this and nothing should - it is a comment in an ignore file. Checks I ran
|
What
.gitignore: ignore.claude/worktrees/(only that subdirectory; the rules under.claude/stay tracked).worktreeinclude: new, copiespubspec_overrides.yamlinto every worktree Claude Code createsWhy
Worktrees were opened beside the checkout as
<repo>-<slug>, so they landed in the workspace directory next to the real repositories, and Claude Code'sEnterWorktreecould not be used at all: it writes to a fixed.claude/worktrees/<slug>.Moving them inside exposes a problem the old layout hid.
pubspec_overrides.yamlis gitignored, so a worktree never receives it, and the absence is silent rather than loud: the siblings resolve from pub.dev,flutter pub getsucceeds, and the suite passes against the PUBLISHED packages while the diff under review is of the local ones. An unreleased sibling API is where that bites.For the copy to be correct the local file needs ABSOLUTE paths, since a relative
../magicresolves to.claude/worktrees/magicfrom inside a worktree. That file is machine-local and not committed, so this PR cannot carry it; the requirement is documented in.worktreeinclude.Testing
The pattern was proven end to end on fluttersdk/magic_starter#124 first: probe worktree opened under the new path,
pubspec_overrides.yamlconfirmed absent, copied in,flutter pub getresolved andpackage_config.jsonpointed at the local checkouts. Here I verified that every rewritten absolute path resolves to a real package directory and thatflutter pub getstill succeeds.No Dart, YAML or
lib/file is touched, so analyze, format and test have nothing to say about this diff.