rfc50: drop re-starting event - #546
Merged
Merged
Conversation
Problem: the exec.eventlog 're-starting' event's name implies that processes are starting, but they are already running. Also, its description says is posted after the exec system "has successfully attached" but the -ing implies the action is not yet complete. This event currently has no users and is confusing. Drop it.
Problem: the exec.eventlog 'reattach' event description is not clear about when the event is posted. Clarify the language. Note: this event is analogous to 'starting' in that it signifies the beginning of the reattach action, not its completion. Both events post no explicit follow-up event on success, and both post a job exception in the main eventlog on failure.
|
|
Contributor
|
Queued — the merge queue status continues in this comment ↓. |
Member
Author
|
Thanks! |
Contributor
Merge Queue Status
This pull request spent 19 seconds in the queue, including 2 seconds running CI. Required conditions to merge
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: the exec.eventlog
re-startingevent description doesn't match what its name implies and it's actually not needed.Drop it.
Also clarify the
reattachevent description.