Skip to content

rfc27: drop sched.queue as scheduler annotation - #547

Merged
mergify[bot] merged 1 commit into
flux-framework:masterfrom
grondo:drop-sched.queue
Aug 13, 2026
Merged

rfc27: drop sched.queue as scheduler annotation#547
mergify[bot] merged 1 commit into
flux-framework:masterfrom
grondo:drop-sched.queue

Conversation

@grondo

@grondo grondo commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Problem: RFC 27 lists sched.queue as a known scheduler annotation, but this annotation is not used anywhere since schedulers do not assign queues.

Drop the annotation to avoid confusion.

For background, Fluxion did set a sched.queue annotation early on when it had a default queue config parameter, but this was removed in flux-framework/flux-sched#971.

Problem: RFC 27 lists `sched.queue` as a known scheduler annotation,
but this annotation is not used anywhere since schedulers do not
assign queues.

Drop the annotation to avoid confusion.
@grondo
grondo requested a review from wihobbs August 12, 2026 18:11
@github-actions

Copy link
Copy Markdown

⚠️ linkcheck failed with status code 2

@wihobbs

wihobbs commented Aug 12, 2026

Copy link
Copy Markdown
Member

I was thinking about this the other day and here's one reason to consider keeping it:

  • With the inclusion of vqueues it might be good to have a record of the non-virtual queue the job actually was scheduled in for historical purposes. Is that data gathered anywhere else in the job's metadata?

edit: if that data is already collected elsewhere, I'm happy to approve this PR.

@milroy agreed with your assessment, btw, that this annotation was probably a relic from early Fluxion.

@grondo

grondo commented Aug 12, 2026

Copy link
Copy Markdown
Contributor Author

With the inclusion of vqueues it might be good to have a record of the non-virtual queue the job actually was scheduled in for historical purposes. Is that data gathered anywhere else in the job's metadata?

I don't think it is, but if that was added, it probably wouldn't be under the sched.* namespace, since queue management is now done at the flux-core level. Some sort of memo or other annotation could be added if sites wish to keep a record of the parent queue to which a vqueue maps on a per-job basis.

@wihobbs

wihobbs commented Aug 12, 2026

Copy link
Copy Markdown
Member

A simple test on tuolumne and a git grep suggests edit: corroborates :) this isn't set anywhere by Fluxion. Approving.

@mergify

mergify Bot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Queued — the merge queue status continues in this comment ↓.

@grondo

grondo commented Aug 13, 2026

Copy link
Copy Markdown
Contributor Author

Thanks! Setting MWP.

@mergify mergify Bot added the queued label Aug 13, 2026
@mergify

mergify Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Merge Queue Status

  • Entered queue2026-08-13 00:22 UTC · Rule: default · triggered by rule rebase and merge when passing all checks
  • Checks skipped · PR is already up-to-date
  • Merged2026-08-13 00:22 UTC · at 72dec599c9927e574d676bd3d9bc979cdcf64a6c · merge

This pull request spent 15 seconds in the queue, including 2 seconds running CI.

Required conditions to merge
  • github-review-approved [🛡 GitHub branch protection]
  • any of [🛡 GitHub branch protection]:
    • check-success = docs/readthedocs.org:flux-rfc
    • check-neutral = docs/readthedocs.org:flux-rfc
    • check-skipped = docs/readthedocs.org:flux-rfc
  • any of [🛡 GitHub branch protection]:
    • check-success = make check
    • check-neutral = make check
    • check-skipped = make check
  • any of [🛡 GitHub branch protection]:
    • check-success = validate commits
    • check-neutral = validate commits
    • check-skipped = validate commits

@mergify
mergify Bot merged commit 3551e05 into flux-framework:master Aug 13, 2026
7 of 8 checks passed
@mergify mergify Bot removed the queued label Aug 13, 2026
@grondo
grondo deleted the drop-sched.queue branch August 13, 2026 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants