Run Redis backed unit tests 1:1 against real Redis#107
Draft
niksy wants to merge 8 commits into
Draft
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
14 tasks
Owner
|
Is it done? @niksy |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR aligns Redis backend unit tests against real Redis so we can test full Redis layer functionality with real Redis client while also preserving mock test. Duplicate tests are removed and only real integration tests are preserved.
Vitest mocking is replaced by Redis client factory. Factory decides which client should be used based on evironment variable.
Integration tests configuration has been simplified to use (Vitest
globalSetupis used for setting up Docker environment). Also, I’ve moved them to default tests but guarded them with real Redis flag usage.I also think that we should completely remove ioredis mock and just use real Redis. There is no benefit in mocking if we can achieve real Redis usage test with our current Docker setup.
This PR is also dependant on #104 so that one should be merged first.
Type of Change
Testing
npm test)npm run lint)npm run build:all)Checklist
as any,@ts-ignore,@ts-expect-error)Additional Notes