Skip to content

Fix: remove all barrel imports and unused deps#1013

Open
santipalenque wants to merge 1 commit into
masterfrom
fix/upload-input-v3-direct-import
Open

Fix: remove all barrel imports and unused deps#1013
santipalenque wants to merge 1 commit into
masterfrom
fix/upload-input-v3-direct-import

Conversation

@santipalenque

@santipalenque santipalenque commented Jul 17, 2026

Copy link
Copy Markdown

https://app.clickup.com/t/9014802374/86baz0zt6

Summary by CodeRabbit

  • Chores
    • Updated the shared UI foundation package to a newer maintenance release.
  • Refactor
    • Improved how form, upload, table, and input components are loaded across the application.
    • No user-facing workflows or component behavior were changed.
  • Tests
    • Updated test coverage and mocks to match the revised component loading approach.
    • Preserved existing coverage for uploads, forms, filtering, and validation behavior.

@coderabbitai

coderabbitai Bot commented Jul 17, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

The foundation dependency is upgraded from 5.0.40 to 5.0.43. UI components and action handlers now use direct module imports instead of barrel exports, and affected Jest mocks are updated accordingly. Several form lifecycle and syntax cleanups preserve existing behavior.

Changes

Foundation Import Migration

Layer / File(s) Summary
Dependency and action handler wiring
package.json, src/actions/...
The foundation dependency is upgraded, and Dropbox sync actions/tests import snackbarErrorHandler from the foundation utilities module.
Form component import cleanup
src/components/forms/...
Form UI dependencies use direct foundation module paths; lifecycle signatures and minor handler/render syntax are simplified without changing behavior.
Upload component module migration
src/components/upload-dialog/index.js, src/pages/companies/..., src/pages/sponsors-global/..., src/pages/sponsors/sponsor-form-item-list-page/...
Upload components use direct modules, and the company dialog test mocks the updated upload path.
Sponsor cart module migration
src/pages/sponsors/sponsor-page/tabs/sponsor-cart-tab/components/...
Sponsor cart form components and tests use direct text-field and form-item-table modules with targeted mocks.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Suggested reviewers: tomrndom, smarcet

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title matches the main change: replacing barrel imports with direct imports and trimming dependency usage.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/upload-input-v3-direct-import

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

package.json

Parsing error: Missing semicolon. (2:8)


Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
src/components/forms/schedule-settings-form/index.js (1)

68-69: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value

Consider removing the console.log in updateFilterOrder.

This debug log was reformatted in this PR but is still a leftover artifact. Since the line was touched, consider removing it to keep production output clean.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/components/forms/schedule-settings-form/index.js` around lines 68 - 69,
Remove the leftover console.log debug statement from updateFilterOrder while
preserving the method’s filter ordering behavior.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@src/components/forms/schedule-settings-form/index.js`:
- Around line 68-69: Remove the leftover console.log debug statement from
updateFilterOrder while preserving the method’s filter ordering behavior.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 1fb8fdac-6467-4938-97d0-7aeb994dcb1c

📥 Commits

Reviewing files that changed from the base of the PR and between 81151db and 85342b8.

⛔ Files ignored due to path filters (1)
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (19)
  • package.json
  • src/actions/__tests__/dropbox-sync-actions.test.js
  • src/actions/dropbox-sync-actions.js
  • src/components/forms/badge-form.js
  • src/components/forms/badge-type-form.js
  • src/components/forms/event-category-group-form.js
  • src/components/forms/event-comment-form.js
  • src/components/forms/room-form.js
  • src/components/forms/schedule-settings-form/index.js
  • src/components/forms/tag-group-form.js
  • src/components/upload-dialog/index.js
  • src/pages/companies/components/__tests__/company-dialog.test.js
  • src/pages/companies/components/company-dialog.js
  • src/pages/sponsors-global/form-templates/sponsor-inventory-popup.js
  • src/pages/sponsors/sponsor-form-item-list-page/components/sponsor-form-item-form.js
  • src/pages/sponsors/sponsor-page/tabs/sponsor-cart-tab/components/client-form/__tests__/client-form.test.js
  • src/pages/sponsors/sponsor-page/tabs/sponsor-cart-tab/components/client-form/index.js
  • src/pages/sponsors/sponsor-page/tabs/sponsor-cart-tab/components/edit-form/__tests__/edit-cart-form.test.js
  • src/pages/sponsors/sponsor-page/tabs/sponsor-cart-tab/components/edit-form/index.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant