chore: quality & housekeeping sweep (TypeScript / Next.js) - #583
Merged
Merged
Conversation
`agent_docs/project-structure.md` asks to be updated whenever a file is added, moved or removed, but seven modules had landed without an entry: `components/ErrorBoundary.tsx`, `components/SidebarResizer.tsx` and the utils `access-log-filter.ts`, `download.ts`, `editor-draft.ts`, `file-import.ts`, `sidebar-width.ts`. Each is inserted at its alphabetical position in the `utils/` list (the `components/` list is grouped, not sorted, so the resizer sits next to `Sidebar.tsx` and the crash guard leads the block) with a one-line description taken from the module's own header comment. Documentation only -- no source file is touched. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016oZDrMULeCJTxz762nC8aH
`.gitignore` listed the bare `.env` only. Next.js also loads `.env.local`, `.env.production` and `.env.*.local`, so a developer following the framework's own convention would have had that file offered by `git add` with nothing stopping the commit. `.dockerignore` already excludes `.env.*`; the two ignore files were out of step. Adds `.env.*` with a `!.env.example` negation so the committed template stays tracked. Verified with `git check-ignore`: `.env.example` is still not ignored, `.env.local` and `.env.production.local` now are. No tracked file changes state. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016oZDrMULeCJTxz762nC8aH
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Autonomous quality & housekeeping sweep over the TypeScript / Next.js stack. Two findings raised, both fixed and both mechanical; the full check chain is green on the final commit.
Merged findings
agent_docs/project-structure.mdsrc/but are absent from the structure tree, whose own header asks to be updated on every add/move/remove:components/ErrorBoundary.tsx,components/SidebarResizer.tsx,utils/access-log-filter.ts,utils/download.ts,utils/editor-draft.ts,utils/file-import.ts,utils/sidebar-width.tsutils/list (thecomponents/list is grouped, not sorted, so the resizer sits next toSidebar.tsxand the crash guard leads the block); each description is taken from the module's own header comment.gitignore.envwas ignored. Next.js also loads.env.local,.env.productionand.env.*.local, so any of those would have been offered bygit addwith nothing stopping the commit..dockerignorealready excludes.env.*— the two ignore files were out of step.env.*added with a!.env.examplenegation. Verified withgit check-ignore:.env.exampleis still not ignored,.env.localand.env.production.localnow are. No tracked file changes stateNo source file under
src/is touched by this PR.Tooling-Status
format:check).prettierrc.json,.prettierignoretsc --noEmit)tsconfig.jsonlint)eslint.config.jstest)vitest.config.tsbuild)next.config.tsChain run in this repo's own order (
CLAUDE.md→ Commands, mirroringdocker-publish.yml):npm ci→format:check→tsc --noEmit→lint→test→build.Deferred
jsx-a11yESLint warnings (0 errors) across 10 components — each is a keyboard-interaction design decision, not a mechanical edit. Already tracked as fix(a11y): graph canvases offer no keyboard path to focus or activate a node #465 and fix(a11y): tab bars lack roving tabindex; StashViewer panels lack aria-controls/tabpanel wiring #457.type/interfacealiases and test seams) — droppingexportis a style call, not dead-code removal; equivalence unclear.Both are recorded in #582.
Keine Version-Bumps enthalten
package.jsonandpackage-lock.jsonare untouched —git diff -- package.json package-lock.jsonis empty. Dependency version bumps and Dependabot PRs (#578, #476, #437, #360, #125) are out of scope for this routine and were not touched.Closes #582
🤖 Generated with Claude Code
https://claude.ai/code/session_016oZDrMULeCJTxz762nC8aH
Generated by Claude Code