Implicit set --compress when specifying --compress-method

[Matthijsy]

When specifying --compress-method without --compress the first argument is ignored. This PR adds a quick check to see that you always specify --compress when you specify a method. There is no need to specify a method when the compression is not happing.

[twiggler]

The logic here correctly catches the edge case where a user supplies a method but forgets the boolean flag.

However, from a UX perspective, if the user explicitly supplies --compress-method, their intent is clearly to compress. Instead of raising a ValueError, would it be cleaner to simply infer args.compress = True if a method is present?

(I approved the pr in case you don't want to pursue this any further)

[Matthijsy]

Good point, I agree that --compress-method should infer --compress as well. I just added that to the PR

[Matthijsy]

@twiggler Anything still needed to get this merged?

[twiggler]

@twiggler Anything still needed to get this merged?

@Matthijsy No, looks good.
The main branch is broken at the moment; after this has been addressed, I will merge it in (probably this week).

[codecov]

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 43.75%. Comparing base (fdd7c1e) to head (e724c42).

Files with missing lines	Patch %	Lines
acquire/utils.py	50.00%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #274   +/-   ##
=======================================
  Coverage   43.74%   43.75%           
=======================================
  Files          26       26           
  Lines        3630     3632    +2     
=======================================
+ Hits         1588     1589    +1     
- Misses       2042     2043    +1     

Flag	Coverage Δ
unittests	43.75% <50.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.