Always use EsxiMemoryManager on ESXi - #311
Merged
Merged
Conversation
Matthijsy
force-pushed
the
hotfix/esxi-context-manager
branch
from
August 3, 2026 09:44
4002808 to
e8130e1
Compare
Schamper
requested changes
Aug 11, 2026
Co-authored-by: Erik Schamper <1254028+Schamper@users.noreply.github.com>
Schamper
approved these changes
Aug 11, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #311 +/- ##
==========================================
+ Coverage 43.75% 43.77% +0.02%
==========================================
Files 26 26
Lines 3632 3630 -2
==========================================
Hits 1589 1589
+ Misses 2043 2041 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Schamper
approved these changes
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the EsxiMemoryManager is only used for the acquisition part. However, this means that other code flows might fail (such as --list-children). This PR changes the behavior by always using the EsxiMemoryManager as long as we are on ESXi.
Fixes #310