fix(i18n): let generate-pot-file import hooks without a site - #758
Merged
surajshetty3416 merged 1 commit intoAug 17, 2026
Merged
Conversation
hooks.py reads frappe.conf at import time. bench generate-pot-file --app builder imports hooks without a site bound, so the proxy raises RuntimeError: object is not bound and extraction never starts. Every recorded run of generate-pot-file.yml has failed this way since the workflow was added on 2026-08-08. The same workflow runs green in frappe/crm and frappe/lms, so a site-less import is the expected contract. Behaviour is unchanged wherever a site is bound; only the site-less import falls back to the default path.
Contributor
Confidence Score: 5/5The PR appears safe to merge with no actionable defects identified. The fallback is limited to the unbound configuration proxy and retains the existing default route path. Reviews (1): Last reviewed commit: "fix(i18n): let generate-pot-file import ..." | Re-trigger Greptile |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #758 +/- ##
===========================================
- Coverage 66.22% 66.21% -0.01%
===========================================
Files 90 90
Lines 10015 10018 +3
===========================================
+ Hits 6632 6633 +1
- Misses 3383 3385 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Merged
|
🎉 This PR is included in version 1.33.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
generate-pot-file.ymlhas never completed successfully. It was added on 2026-08-08 and has run on 08-08, 08-09 and 08-16. All three runs failed the same way:hooks.pyreadsfrappe.confat import time. That works wherever a site is bound, butbench generate-pot-file --app builderimports hooks without one, so the proxy raises before extraction starts.The same workflow runs green in
frappe/crmandfrappe/lms, so a site-less import is the expected contract and the fix belongs in the app rather than in CI.Scheduled runs fail quietly, so nothing surfaces this.
builder/locale/main.potwas last updated by hand in #721 on 2026-08-13, not by the workflow. The roughly 190 strings wrapped in #746 and #750 are in the source but never reach the POT, so no language can translate them yet.Behaviour is unchanged wherever a site is bound. Only the site-less import falls back to the default path.
Not runtime-tested: I have no bench here. The failing job log and the passing sibling workflows are the evidence I have.