ci: let the release job install past frontend peer conflicts - #788
Merged
surajshetty3416 merged 1 commit intoAug 28, 2026
Merged
Conversation
The frontend moved to eslint 10 while eslint-plugin-import still peers on eslint <= 9. yarn only warns, so it landed, but the release job runs npm at the workspace root and npm refuses with ERESOLVE, so v1.33.0 never got past "Setup dependencies". Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
|
Tick the box to add this pull request to the merge queue (same as
|
|
🎉 This PR is included in version 1.33.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #788 +/- ##
=======================================
Coverage 66.06% 66.06%
=======================================
Files 93 93
Lines 10386 10386
=======================================
Hits 6862 6862
Misses 3524 3524 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v1.33.0 release never ran: the job failed at Setup dependencies, before
semantic-releasewas invoked.#732bumped the frontend to eslint 10 whileeslint-plugin-import@^2.27.5still peers on eslint <= 9. We install with yarn v1, which only warns about peer ranges, so it landed clean. The release job is the one place we runnpmat the workspace root, and npm enforces peers, so it refuses to install the two semantic-release plugins.Adding
--legacy-peer-depsputs npm on the same footing as the yarn install the rest of the repo uses.Verified on a clean checkout of
master(2ea28db): reproduced the ERESOLVE, then confirmed the flag installs, all plugins load, and a--dry-runresolvesThe next release version is 1.33.0(minor, 928 commits).Merging this pushes
masterand re-triggers the release.