Skip to content

ci: let the release job install past frontend peer conflicts - #788

Merged
surajshetty3416 merged 1 commit into
frappe:masterfrom
surajshetty3416:fix/release-workflow-peer-deps
Aug 28, 2026
Merged

ci: let the release job install past frontend peer conflicts#788
surajshetty3416 merged 1 commit into
frappe:masterfrom
surajshetty3416:fix/release-workflow-peer-deps

Conversation

@surajshetty3416

@surajshetty3416 surajshetty3416 commented Aug 28, 2026

Copy link
Copy Markdown
Member

The v1.33.0 release never ran: the job failed at Setup dependencies, before semantic-release was invoked.

npm error code ERESOLVE
npm error Found: eslint@10.8.1
npm error Could not resolve dependency:
npm error peer eslint@"^2 || ... || ^9" from eslint-plugin-import@2.32.0

#732 bumped the frontend to eslint 10 while eslint-plugin-import@^2.27.5 still peers on eslint <= 9. We install with yarn v1, which only warns about peer ranges, so it landed clean. The release job is the one place we run npm at the workspace root, and npm enforces peers, so it refuses to install the two semantic-release plugins.

Adding --legacy-peer-deps puts npm on the same footing as the yarn install the rest of the repo uses.

Verified on a clean checkout of master (2ea28db): reproduced the ERESOLVE, then confirmed the flag installs, all plugins load, and a --dry-run resolves The next release version is 1.33.0 (minor, 928 commits).

Merging this pushes master and re-triggers the release.

The frontend moved to eslint 10 while eslint-plugin-import still peers on
eslint <= 9. yarn only warns, so it landed, but the release job runs npm
at the workspace root and npm refuses with ERESOLVE, so v1.33.0 never got
past "Setup dependencies".

Co-Authored-By: Claude <noreply@anthropic.com>
@mergify

mergify Bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

@surajshetty3416
surajshetty3416 merged commit 88bd832 into frappe:master Aug 28, 2026
7 checks passed
@surajshetty3416
surajshetty3416 deleted the fix/release-workflow-peer-deps branch August 28, 2026 10:20
@github-actions

Copy link
Copy Markdown

🎉 This PR is included in version 1.33.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@codecov

codecov Bot commented Aug 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.06%. Comparing base (2ea28db) to head (6ae9277).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #788   +/-   ##
=======================================
  Coverage   66.06%   66.06%           
=======================================
  Files          93       93           
  Lines       10386    10386           
=======================================
  Hits         6862     6862           
  Misses       3524     3524           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant