Skip to content

fix: stepper arrows on grid Columns and Rows inputs - #789

Open
SmrutiSawant wants to merge 1 commit into
frappe:developfrom
SmrutiSawant:fix-arrowKeys
Open

fix: stepper arrows on grid Columns and Rows inputs#789
SmrutiSawant wants to merge 1 commit into
frappe:developfrom
SmrutiSawant:fix-arrowKeys

Conversation

@SmrutiSawant

Copy link
Copy Markdown
Contributor

Problem
The up/down stepper arrows never render on the Columns and Rows inputs in the Layout section, though every other field has them.

Cause
BlockGridLayoutHandler binds a number (parseRepeatFunction uses parseInt), but Input.vue's isStrictNumber returned false for any non-string, so canShowArrows short-circuited.

Changes
Input.vue — isStrictNumber accepts finite numbers.

Before:

v1.mp4

Now:

v2.mp4

@greptile-apps

greptile-apps Bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Confidence Score: 5/5

The PR appears safe to merge.

The finite-number check restores arrows for numeric grid bindings while rejecting NaN and infinities; no concrete regression was identified.

Reviews (1): Last reviewed commit: "fix: stepper arrows on grid Columns and ..." | Re-trigger Greptile

@codecov

codecov Bot commented Aug 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.06%. Comparing base (12c787a) to head (8a6ebde).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #789   +/-   ##
========================================
  Coverage    66.06%   66.06%           
========================================
  Files           93       93           
  Lines        10386    10386           
========================================
  Hits          6862     6862           
  Misses        3524     3524           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant