-
-
Notifications
You must be signed in to change notification settings - Fork 138
Proposal/teacher onboarding mvp #595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
CarlyAThomas
wants to merge
18
commits into
freeCodeCamp:main
Choose a base branch
from
CarlyAThomas:proposal/teacher-onboarding-mvp
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
8417c72
feat: add teacher onboarding MVP updates
CarlyAThomas d081915
docs: update TODO with join link review section and ZZZ notes status
CarlyAThomas eb5f9cb
test: update classInviteTable snapshot after GraphQL/StudentInvitesPa…
CarlyAThomas d91d4dd
feat: teacher onboarding MVP (remove student-only components)
CarlyAThomas 6b85ae6
feat: add teacher invite email, feature flag, acceptance flow, and tests
CarlyAThomas 2ce56d9
feat: add teacher invite implementation files (feature flag, email, a…
CarlyAThomas bb1cf13
chore: remove test files with external dependencies
CarlyAThomas 391e149
docs: update TODO to note manual integration testing
CarlyAThomas 7ccaf64
chore: remove onboarding notes docs from teacher MVP branch
CarlyAThomas b612767
chore: ignore and untrack development/production env files
CarlyAThomas c277ad1
docs: add tracked env templates for development and production
CarlyAThomas 7d5ef35
fix: remove nested anchors in Link components and refactor email util…
CarlyAThomas 9ac4f49
feat: polish teacher invite flow and styling
CarlyAThomas 6cbab30
fix: quote Accept Invitation in onboarding email text
CarlyAThomas 867b52d
fix: remove unrelated StudentInvitation model, squash to single migra…
CarlyAThomas 4987938
fix: don't hardcode Auth0 in teacher invite sign-in
CarlyAThomas a80a4c4
test: cover teacher invitation status transitions and email matching
CarlyAThomas 96fd310
test: cover access control on /classes for non-teacher accounts
CarlyAThomas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| GITHUB_OAUTH_PROVIDER_ENABLED = "true" | ||
| DANGEROUS_ACCOUNT_LINKING_ENABLED = "true" | ||
| TEACHER_INVITES_ENABLED = "true" | ||
|
|
||
| # Teacher invitation email delivery for local testing | ||
| # Replace these with your actual SMTP provider credentials | ||
| SMTP_HOST=smtp.gmail.com | ||
| SMTP_PORT=587 | ||
| SMTP_SECURE=false | ||
| SMTP_USER=your-email@gmail.com | ||
| SMTP_PASS=your-app-password | ||
| SMTP_FROM="freeCodeCamp Classroom <no-reply@classroom.local>" | ||
| CLASSROOM_APP_BASE_URL=http://localhost:3001 |
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| GITHUB_OAUTH_PROVIDER_ENABLED = "false" | ||
| DANGEROUS_ACCOUNT_LINKING_ENABLED = "false" | ||
| TEACHER_INVITES_ENABLED = "true" | ||
|
|
||
| # Teacher invitation email delivery for production | ||
| # Replace these with your production SMTP provider credentials | ||
| SMTP_HOST=smtp.sendgrid.net | ||
| SMTP_PORT=587 | ||
| SMTP_SECURE=false | ||
| SMTP_USER=apikey | ||
| SMTP_PASS=your-sendgrid-api-key | ||
| SMTP_FROM="freeCodeCamp Classroom <no-reply@classroom.freecodecamp.org>" | ||
| CLASSROOM_APP_BASE_URL=https://classroom.freecodecamp.org |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The documentation is great, but I'm concerned the README.md is getting too long. Can you create a subpage for this documentation and link it from the README?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have a separate issue & PR for this! Issue #593 and PR #605