ci(v37-dev): add v37-dev to pull_request allowlists so v37-dev Drops get the real matrix - #1070
Merged
Merged
Conversation
PRs based on v37-dev previously matched no CI allowlist, so GitHub ran only attribution-gate + automerge evaluate no-op from the base-branch workflow files (pull_request uses the BASE ref workflow). Add v37-dev to on.pull_request.branches in build.yml, coin-matrix.yml (full 6-coin matrix), and codeql-analysis.yml so every v37-dev Drop gets the same aggregate / path-filter / platform-coverage / coin-matrix / CodeQL / platform-build coverage as master before it can merge up.
The Windows x86_64 Verify/Package steps hardcoded Copy-Item of libsecp256k1-6.dll. Upstream unpinned secp256k1 bumped the SONAME 6->7, so the runner emits libsecp256k1-7.dll and every copy exit-1s, failing the Windows leg of this v37-dev allowlist PR for a reason already fixed on master (#1069). Glob all three copies so any SONAME bump is copied. build.yml only; release.yml is not exercised by pull_request checks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the shared-infra CI-trigger defect (routed from v37-dev-steward via integrator, verified on v37-dev HEAD 86c46bb).
For pull_request events GitHub runs the workflow file from the BASE branch. v37-dev was in none of the CI allowlists, so any PR based on v37-dev (Drop-3 #1068 and every prior v37-dev Drop) got only attribution-gate + the automerge evaluate no-op — no aggregate / path-filter / platform-coverage / coin-matrix / CodeQL / platform builds. Structurally impossible to get the matrix, not a per-SHA hollow-green.
Change (mechanism (a) — edit the copies ON v37-dev so the fix is immediately effective for v37-dev-based PRs; no master merge-down dependency):
CI contract set to the master bar: v37-dev Drops now get full 6-coin coverage + CodeQL, so a v37-dev->master merge cannot surprise master with red or unscanned code.
safe-cosmetic-automerge.yml intentionally untouched — its BASE_REQUIRED=master guard already no-ops on non-master bases.
Not self-merging — integrator/operator gate.