Skip to content

test(gui): give the e2e desktop window a 16:9 shape #380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fstubner merged 1 commit into from
Sep 8, 2026
Merged

test(gui): give the e2e desktop window a 16:9 shape #380

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion apps/netscli-gui/e2e/tauri-render.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,16 @@ import {
} from './tauri-render/scenarios.mjs';
import { alignmentReport } from './tauri-render/scenarios/helpers/alignment.mjs';

const DESKTOP_WINDOW = { x: 0, y: 0, width: 1000, height: 970 };
/* 16:9, because that is the shape a desktop app is actually used in.
*
* This was 1000x970, very nearly square, which no monitor is. The captures
* came out 1250x1213 and anything showing them at 16:9 cropped the bottom
* third -- the detail pane, the command strip and the status bar, which is
* to say every part of the window a screenshot of a scan is taken FOR.
*
* The narrow window below stays as it is: it exists to exercise the
* responsive breakpoint, so its shape is the point rather than a mistake. */
const DESKTOP_WINDOW = { x: 0, y: 0, width: 1600, height: 900 };
const NARROW_WINDOW = { width: 520, height: 720 };

let nativeDriverProcess;
Expand Down