Fix job_config_init profile wiring and legacy version default - #1685
Merged
Conversation
profile_job_config_init wrote job_conf.yml into the profile and then stored the profile's own planemo_profile_options.json path as job_config_file, so runs against the profile never saw the generated configuration. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01C5F4LLXH1Rpt2MCLQCgwgU
The click default pinned 24.2, so omitting --galaxy_version produced the legacy TPV layout - dynamic runner, rules_module, and a tpv.yml the user has to write - while gxjobconfinit's own default is 25.0. Passing None through lets that default apply and move with the library. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01C5F4LLXH1Rpt2MCLQCgwgU
mvdbeek
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two independent bugs in
job_config_init/profile_job_config_init, both found while addressing review comments on #1683.profile_job_config_initrecords the wrong fileinitialize_job_configwritesjob_conf.ymlinto the profile directory and then stores the profile's ownplanemo_profile_options.jsonpath asjob_config_file:A profile set up this way hands Galaxy its options JSON as a job configuration, so the generated runner configuration never takes effect. Before:
tests/test_cmd_profile_job_config_init.pyonly asserted exit codes, which is why this survived. It now asserts the recorded path and parses the config it points at.--galaxy_versiondefaults to the legacy layoutgalaxy_version_option()pins the click default to"24.2", whilegxjobconfinitdefaults to"25.0"when the value isNoneand branches ongalaxy_version < "25.0". Omitting the flag therefore selects the legacy configuration rather than a modern one.For
--runner slurm --singularitythe output is byte-identical either way. For--tpvit is not:--galaxy_version 25.024.2)dynamic_tpvdynamic+type: python+rules_module: tpv.rulestpv_configstpv.ymlthe user must createtpvdb_slurmdestinationPassing
Nonethrough lets the library's default apply and move with it. Callers that want the old layout still pass--galaxy_version 24.2explicitly, which the existingtest_job_config_init_24_2covers.Validation
pytest tests/test_cmd_job_config_init.py tests/test_cmd_profile_job_config_init.py— 8 passed; both new tests confirmed red before the fixesflake8,black --check,isort --check-onlyclean on all changed filesdocs/commands/{job_config_init,profile_job_config_init}.rstregenerated withscripts/commands_to_rst.py. The generator also rewrites eleven unrelated command docs that have drifted from merged PRs; those are left alone here.profile_create+profile_job_config_init --runner slurm --tpv --singularitynow yieldsdynamic_tpv, an uncommentedtpvdb_slurmdestination,https://gxy.io/tpv/db.yml,singularity_cmd: singularity, a commenteddrmaa_library_path,native_specification,tmp_dir: true, and a profile recording the realjob_conf.yml.Relationship to #1683
#1683 drops
--galaxy_version 25.0from its examples and recommendsprofile_job_config_init, per review there. Both of those are only correct once this lands, so this should merge first.🤖 Generated with Claude Code
https://claude.ai/code/session_01C5F4LLXH1Rpt2MCLQCgwgU