Skip to content

Honor Galaxy test timeouts across uploads and workflows - #1687

Merged
jmchilton merged 5 commits into
galaxyproject:masterfrom
jmchilton:honor-galaxy-test-timeout
Sep 2, 2026
Merged

Honor Galaxy test timeouts across uploads and workflows#1687
jmchilton merged 5 commits into
galaxyproject:masterfrom
jmchilton:honor-galaxy-test-timeout

Conversation

@jmchilton

@jmchilton jmchilton commented Aug 26, 2026

Copy link
Copy Markdown
Member

Summary

  • apply one monotonic deadline across uploads, job execution, and workflow polling
  • allow one final state poll at the deadline before timing out
  • report whether uploads, a job, or a workflow invocation timed out
  • propagate test_timeout through file-based engine execution and workflow_test_on_invocation
  • keep the timeout argument typed and accepted by the Galaxy, cwltool, and Toil engine interfaces

Tests

  • 29 focused polling, activity, engine, and workflow-invocation tests
  • Black, isort, Ruff, and diff checks

@mvdbeek mvdbeek left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The implementation looks fine, but the tests are very mock / patch heavy, are you happy with those ? (also local imports)

@jmchilton

Copy link
Copy Markdown
Member Author

Of course I am not 😅😢.

@jmchilton
jmchilton force-pushed the honor-galaxy-test-timeout branch from 86a40af to 7b8803f Compare August 29, 2026 14:41
@jmchilton
jmchilton merged commit 13e3117 into galaxyproject:master Sep 2, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants