[WIP] Run package-installed Galaxy through Gravity - #1691
Open
jmchilton wants to merge 18 commits into
Open
Conversation
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Status
This is a WIP architecture spike based on #1690. It reuses that PR's checkout-independent configuration work, YAML-tool support, execution fixes, and test infrastructure, but replaces Planemo's ownership of the embedded Galaxy lifecycle with Gravity-managed subprocesses.
The motivation and broader package-installed Galaxy discussion are in #1690. This PR explores the alternative raised there and in #1690 (comment).
The incremental Gravity implementation is currently the final commit, de66cd2. If this direction is accepted, the intended next step is to reshape #1690 around this approach, not permanently expose two competing package-installed lifecycle models.
What differs from #1690
installed_galaxyengine that invokes thegalaxycommand from Planemo's Python environment.virtualenvsetting to bind all services to Planemo's environment, avoiding PATH-dependent executable selection.In particular, this removes the need for Planemo to manage Galaxy application globals, uvicorn threads, Celery worker internals, logging restoration, or ordered in-process teardown. Gravity remains the Galaxy service-lifecycle boundary.
Current configuration
The generated Gravity configuration currently uses:
process_manager: multiprocessingservice_command_style: directgalaxy.internalandgalaxy.externalqueuesThese settings are deliberately small and test-oriented; they are not proposed as new general Gravity defaults.
Evidence so far
planemo servestarts successfully and terminal Ctrl-C shuts down Planemo, Gravity, Gunicorn, and Celery without leaving a listener behind.One initial A/B run measured approximately 29.1 seconds for the in-process engine and 32.5 seconds for the Gravity engine. That is only a preliminary data point, but it suggests Gravity preserves most of the startup improvement while retaining normal Galaxy process isolation.
Before this is ready
embedded_galaxyimplementation in [WIP] Add an embedded Galaxy engine for package-installed Galaxy #1690. That is the current recommendation.