Use DCO instead of CLA - #1058
Conversation
Signed-off-by: Marc Vornetran <marc.vornetran@sap.com>
✅ Deploy Preview for gardener-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configurationConfiguration used: Path: .coderabbit.yml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
gardener-prow
Bot
added
cla: yes
|
|
||
| * Code contributions must be licensed under the [Apache 2.0 License](http://www.apache.org/licenses/LICENSE-2.0) | ||
| * Documentation contributions must be licensed under the [Creative Commons Attribution 4.0 International License](https://creativecommons.org/licenses/by/4.0/legalcode) | ||
| * You need to sign the Contributor License Agreement. We are using *[CLA assistant](https://cla-assistant.io/)*, which provides a click-through workflow for accepting the CLA. For company contributors, the company also needs to sign a corporate license agreement. |
There was a problem hiding this comment.
Do we still require the second part of this bullet?
For company contributors, the company also needs to sign a corporate license agreement.
BoHristova
left a comment
BoHristova
left a comment
There was a problem hiding this comment.
Just a couple of nitpicks ;)
|
/assign |
Signed-off-by: Marc Vornetran <marc.vornetran@sap.com>
| if ! grep -qF "$SIGNOFF" "$1"; then | ||
| printf "\n%s\n" "$SIGNOFF" >> "$1" | ||
| fi |
There was a problem hiding this comment.
Should we use a solution based on git interpret-trailers instead? The default template provided by git (.git/hooks/prepare-commit-msg.sample in any git repository) uses git interpret-trailers instead of just appending to the commit message. Then again this solution might be a bit more readable.
WDYT?
There was a problem hiding this comment.
I didn't know about the sample hook files and git interpret-trailers. By far the better and simpler solution!
Tested with the commit itself: 7271c52
Signed-off-by: Marc Vornetran <marc.vornetran@sap.com>
|
LGTM label has been added. DetailsGit tree hash: 537469d743a04cd3bcf80dc7aeff263e78899e75 |
3 participants
How to categorize this PR?
/kind enhancement
What this PR does / why we need it:
Which issue(s) this PR fixes:
Part of: gardener/org#27
Special notes for your reviewer:
Relevant page of the preview deployment:
https://deploy-preview-1058--gardener-docs.netlify.app/contribute/contribution-process/contributor-guide/#developer-certificate-of-origin
/cc @ScheererJ